Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTB House Bid Adapter: updated supply chain support, included floor module support and identity module support (eids) #6721

Merged
merged 4 commits into from
May 10, 2021
Merged

RTB House Bid Adapter: updated supply chain support, included floor module support and identity module support (eids) #6721

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
950ac9b
RTB House Bid Adapter: updated supply chain support, included floor m…
rtbh-lotani May 6, 2021
b9042c3
includes fix
FilipWitkowski-RTBHouse May 10, 2021
f2b3cc1
Revert "includes fix"
FilipWitkowski-RTBHouse May 10, 2021
60eb74e
RTB House Bid Adapter: includes fix
FilipWitkowski-RTBHouse May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 38 additions & 9 deletions modules/rtbhouseBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ const BIDDER_CODE = 'rtbhouse';
const REGIONS = ['prebid-eu', 'prebid-us', 'prebid-asia'];
const ENDPOINT_URL = 'creativecdn.com/bidder/prebid/bids';
const DEFAULT_CURRENCY_ARR = ['USD']; // NOTE - USD is the only supported currency right now; Hardcoded for bids
const SUPPORTED_MEDIA_TYPES = [BANNER, NATIVE];
const TTL = 55;

// Codes defined by OpenRTB Native Ads 1.1 specification
Expand Down Expand Up @@ -34,7 +35,7 @@ export const OPENRTB = {

export const spec = {
code: BIDDER_CODE,
supportedMediaTypes: [BANNER, NATIVE],
supportedMediaTypes: SUPPORTED_MEDIA_TYPES,

isBidRequestValid: function (bid) {
return !!(includes(REGIONS, bid.params.region) && bid.params.publisherId);
Expand All @@ -55,6 +56,23 @@ export const spec = {
request.regs = {ext: {gdpr: gdpr}};
request.user = {ext: {consent: consentStr}};
}
if (validBidRequests[0].schain) {
const schain = mapSchain(validBidRequests[0].schain);
if (schain) {
request.ext = {
schain: schain,
}
}
}

if (validBidRequests[0].userIdAsEids) {
const eids = { eids: validBidRequests[0].userIdAsEids };
if (request.user && request.user.ext) {
request.user.ext = { ...request.user.ext, ...eids };
} else {
request.user = {ext: eids};
}
}

return {
method: 'POST',
Expand Down Expand Up @@ -85,6 +103,22 @@ export const spec = {
};
registerBidder(spec);

/**
* @param {object} slot Ad Unit Params by Prebid
* @returns {int} floor by imp type
*/
function applyFloor(slot) {
const floors = [];
if (typeof slot.getFloor === 'function') {
Object.keys(slot.mediaTypes).forEach(type => {
if (SUPPORTED_MEDIA_TYPES.includes(type)) {
floors.push(slot.getFloor({ currency: DEFAULT_CURRENCY_ARR[0], mediaType: type, size: slot.sizes || '*' }).floor);
}
});
}
return floors.length > 0 ? Math.max(...floors) : parseFloat(slot.params.bidfloor);
}

/**
* @param {object} slot Ad Unit Params by Prebid
* @returns {object} Imp by OpenRTB 2.5 §3.2.4
Expand All @@ -97,9 +131,9 @@ function mapImpression(slot) {
tagid: slot.adUnitCode.toString()
};

const bidfloor = parseFloat(slot.params.bidfloor);
const bidfloor = applyFloor(slot);
if (bidfloor) {
imp.bidfloor = bidfloor
imp.bidfloor = bidfloor;
}

return imp;
Expand Down Expand Up @@ -151,12 +185,7 @@ function mapSource(slot) {
const source = {
tid: slot.transactionId,
};
const schain = mapSchain(slot.schain);
if (schain) {
source.ext = {
schain: schain
}
}

return source;
}

Expand Down
96 changes: 62 additions & 34 deletions test/spec/modules/rtbhouseBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,38 +51,7 @@ describe('RTBHouseAdapter', () => {
});

describe('buildRequests', function () {
let bidRequests = [
{
'bidder': 'rtbhouse',
'params': {
'publisherId': 'PREBID_TEST',
'region': 'prebid-eu',
'test': 1
},
'adUnitCode': 'adunit-code',
'mediaTypes': {
'banner': {
'sizes': [[300, 250], [300, 600]],
}
},
'bidId': '30b31c1838de1e',
'bidderRequestId': '22edbae2733bf6',
'auctionId': '1d1a030790a475',
'transactionId': 'example-transaction-id',
'schain': {
'ver': '1.0',
'complete': 1,
'nodes': [
{
'asi': 'directseller.com',
'sid': '00001',
'rid': 'BidRequest1',
'hp': 1
}
]
}
}
];
let bidRequests;
const bidderRequest = {
'refererInfo': {
'numIframes': 0,
Expand All @@ -92,6 +61,41 @@ describe('RTBHouseAdapter', () => {
}
};

beforeEach(() => {
bidRequests = [
{
'bidder': 'rtbhouse',
'params': {
'publisherId': 'PREBID_TEST',
'region': 'prebid-eu',
'test': 1
},
'adUnitCode': 'adunit-code',
'mediaTypes': {
'banner': {
'sizes': [[300, 250], [300, 600]],
}
},
'bidId': '30b31c1838de1e',
'bidderRequestId': '22edbae2733bf6',
'auctionId': '1d1a030790a475',
'transactionId': 'example-transaction-id',
'schain': {
'ver': '1.0',
'complete': 1,
'nodes': [
{
'asi': 'directseller.com',
'sid': '00001',
'rid': 'BidRequest1',
'hp': 1
}
]
}
}
];
});

it('should build test param into the request', () => {
let builtTestRequest = spec.buildRequests(bidRequests, bidderRequest).data;
expect(JSON.parse(builtTestRequest).test).to.equal(1);
Expand Down Expand Up @@ -177,6 +181,23 @@ describe('RTBHouseAdapter', () => {
expect(data.source.tid).to.equal('example-transaction-id');
});

it('should include bidfloor from floor module if avaiable', () => {
const bidRequest = Object.assign([], bidRequests);
bidRequest[0].getFloor = () => ({floor: 1.22});
const request = spec.buildRequests(bidRequest, bidderRequest);
const data = JSON.parse(request.data);
expect(data.imp[0].bidfloor).to.equal(1.22)
});

it('should use bidfloor from floor module if both floor module and bid floor avaiable', () => {
const bidRequest = Object.assign([], bidRequests);
bidRequest[0].getFloor = () => ({floor: 1.22});
bidRequest[0].params.bidfloor = 0.01;
const request = spec.buildRequests(bidRequest, bidderRequest);
const data = JSON.parse(request.data);
expect(data.imp[0].bidfloor).to.equal(1.22)
});

it('should include bidfloor in request if available', () => {
const bidRequest = Object.assign([], bidRequests);
bidRequest[0].params.bidfloor = 0.01;
Expand All @@ -185,11 +206,11 @@ describe('RTBHouseAdapter', () => {
expect(data.imp[0].bidfloor).to.equal(0.01)
});

it('should include source.ext.schain in request', () => {
it('should include schain in request', () => {
const bidRequest = Object.assign([], bidRequests);
const request = spec.buildRequests(bidRequest, bidderRequest);
const data = JSON.parse(request.data);
expect(data.source.ext.schain).to.deep.equal({
expect(data.ext.schain).to.deep.equal({
'ver': '1.0',
'complete': 1,
'nodes': [
Expand All @@ -203,6 +224,13 @@ describe('RTBHouseAdapter', () => {
});
});

it('should include source.tid in request', () => {
const bidRequest = Object.assign([], bidRequests);
const request = spec.buildRequests(bidRequest, bidderRequest);
const data = JSON.parse(request.data);
expect(data.source).to.have.deep.property('tid');
});

it('should not include invalid schain', () => {
const bidRequest = Object.assign([], bidRequests);
bidRequest[0].schain = {
Expand Down