AOL Bid Adapter: Remove validation of bidder specific video params for Nexage endpoint call formation #6766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @slimkrazy |
|
This pull request introduces 1 alert and fixes 2 when merging 82709a8 into 05f86d7 - view on LGTM.com new alerts:
fixed alerts:
|
ChrisHuie
approved these changes
May 17, 2021
|
@ChrisHuie test issues appear unrelated, looking for a merge on this |
ChrisHuie
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This brings the AOL adapter into compliance with 5.0 requirement outlined at #6512
AOL is welcome to recommit these validations to function from either mediatypes.video or their own parameters; however they have said they are planning to deprecate this adapter altogether in other threads and also the onevideo adapter is where they concentrate their video demand. It isn't actually clear if this adapter still functions for video demand, but it seems unlikely to for long if it does now.
Additionally, their documentation makes no mention of Video support at https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/aol.md or any other place.