sspBC Bid Adapter: add bidfloor to imp and other updates to bid adapter #6820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update master branch of grupawp/Prebid.js
Update tests for sspBC adapter: - change userSync test (due to tcf param appended in v4.6) - add tests for onBidWon and onTimeout
Update master branch of grupawp/Prebid.js
…old module (sspBCAdapter)
Update sspbc 4.9 branch
ChrisHuie
changed the title
|
This looks to be working for me. There's one documentation update I think you need, wouldn't you want to show Floors Module Support as yes on your dev-docs page? Any other edits you think you need? |
|
Hmm... No, I think support for getFloor is the only one. Added in this pull request: prebid/prebid.github.io#2992 |
|
Looks good! |
|
@ChrisHuie Is there an issue with this? |
stsepelin
pushed a commit
to cointraffic/Prebid.js
that referenced
this pull request
May 28, 2021
…er (prebid#6820) * Update tests for sspBC adapter Update tests for sspBC adapter: - change userSync test (due to tcf param appended in v4.6) - add tests for onBidWon and onTimeout * [sspbc-adapter] Update to v4.8 (floorprices, usersync, code cleaning) * [sspbc-adapter] remove bidloor param from md. Remove unused test for old module (sspBCAdapter) Co-authored-by: Wojciech Biały <wb@WojciechBialy.local>
prebidtappx
pushed a commit
to prebidtappx/Prebid.js
that referenced
this pull request
Nov 15, 2021
…er (prebid#6820) * Update tests for sspBC adapter Update tests for sspBC adapter: - change userSync test (due to tcf param appended in v4.6) - add tests for onBidWon and onTimeout * [sspbc-adapter] Update to v4.8 (floorprices, usersync, code cleaning) * [sspbc-adapter] remove bidloor param from md. Remove unused test for old module (sspBCAdapter) Co-authored-by: Wojciech Biały <wb@WojciechBialy.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Update sspBCBidAdapter to a new version, with following changes: