-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prebid Server Bid Adapter: normalize pbs adapter auction ids #6836
Closed
idettman
wants to merge
92
commits into
prebid:master
from
rubicon-project:normalize-pbjs-pbs-auction-ids
Closed
Changes from all commits
Commits
Show all changes
92 commits
Select commit
Hold shift + click to select a range
8d635ff
Add microadBidAdapter
3055b90
Remove unnecessary encodeURIComponent from microadBidAdapter
67fb91b
Submit Advangelists Prebid Adapter
3ebb916
Submit Advangelists Prebid Adapter 1.1
4f5c451
Correct procudtion endpoint for prebid
2dc6d1d
Merge branch 'microad-bid-adapter' of git://github.com/strong-zero/Pr…
fa3e081
Merge remote-tracking branch 'origin/master' into master-rubicon-clean
600a46e
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
7f578b3
Merge branch 'master' of https://github.com/prebid/Prebid.js
176a312
Merge branch 'master' of https://github.com/prebid/Prebid.js
9abf89c
Merge branch 'master' of https://github.com/prebid/Prebid.js
6ce04ab
Merge remote-tracking branch 'upstream/master'
415e2f6
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
61fb82c
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
3cc4c67
analytics update with wrapper name
cd81e02
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
e2b4e04
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
53b5970
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
5c00ed5
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
28848ad
reverted error merge
ab635ee
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
93308f5
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
1cfd52d
Merge branch 'master' of https://github.com/prebid/Prebid.js
d619807
Merge branch 'master' of https://github.com/prebid/Prebid.js
9893f0f
Merge branch 'master' of https://github.com/prebid/Prebid.js
986a251
Merge remote-tracking branch 'upstream/master'
2cae7c0
Merge branch 'master' of https://github.com/prebid/Prebid.js into ori…
d7fd252
Merge branch 'master' of https://github.com/prebid/Prebid.js
c7c01ba
Merge branch 'master' of https://github.com/prebid/Prebid.js
24a28aa
Merge branch 'master' of https://github.com/prebid/Prebid.js
7a1a4ec
Merge branch 'master' of https://github.com/rubicon-project/Prebid.js
4173d16
Merge branch 'master' of https://github.com/prebid/Prebid.js
ca13952
update changed default value of netRevenue to true
0b6cd48
Merge branch 'master' of https://github.com/prebid/Prebid.js
5f0110d
Merge branch 'master' of https://github.com/prebid/Prebid.js
f930a34
Merge remote-tracking branch 'upstream/master'
9bff282
Merge branch 'master' of https://github.com/prebid/Prebid.js
712ec9e
Merge branch 'master' of https://github.com/prebid/Prebid.js
f192f65
Merge branch 'master' of https://github.com/prebid/Prebid.js
006f53c
Merge branch 'master' of https://github.com/prebid/Prebid.js
0341150
Merge branch 'master' of https://github.com/prebid/Prebid.js
fa59897
Merge branch 'master' of https://github.com/prebid/Prebid.js
dcff2cf
Merge branch 'master' of https://github.com/prebid/Prebid.js
0222ce2
Merge branch 'master' of https://github.com/prebid/Prebid.js
227beca
Merge branch 'master' of https://github.com/prebid/Prebid.js
dc3ee49
Merge branch 'master' of https://github.com/rubicon-project/Prebid.js
9a5a08d
Merge branch 'master' of https://github.com/prebid/Prebid.js
35ea5d4
Merge branch 'master' of https://github.com/prebid/Prebid.js
f89b71c
Merge branch 'master' of https://github.com/prebid/Prebid.js
4e1679b
Re-add rubicon analytics without deprecated getTopWindowUrl util
fd80acd
Cache referrer on auction_init instead of bid_requested
2ab26a3
Merge pull request #51 from rubicon-project/rubicon-analytics-3.0
msm0504 7de7ca6
Merge branch 'master' of https://github.com/rubicon-project/Prebid.js
5f1fe06
Merge branch 'master' of https://github.com/prebid/Prebid.js
60b5ad8
Merge branch 'master' of https://github.com/prebid/Prebid.js
5f44edd
Merge branch 'master' of https://github.com/rubicon-project/Prebid.js
4809354
Merge branch 'master' of https://github.com/prebid/Prebid.js
8d8bdff
Merge branch 'master' of https://github.com/prebid/Prebid.js
a1a2318
Merge branch 'master' of https://github.com/prebid/Prebid.js
ac2ac12
Merge branch 'master' of https://github.com/prebid/Prebid.js
5ce8787
Merge branch 'master' of https://github.com/rubicon-project/Prebid.js
6c2bdec
Merge branch 'master' of https://github.com/prebid/Prebid.js
a54a491
Merge branch 'master' of https://github.com/prebid/Prebid.js
889178d
Merge branch 'master' of https://github.com/prebid/Prebid.js
40cba46
Merge branch 'master' of https://github.com/prebid/Prebid.js
cc5d929
Merge remote-tracking branch 'remote/master'
5574a52
merged remote master changes
ba62245
Merge branch 'master' of https://github.com/prebid/Prebid.js
1fe62f9
Merge branch 'master' of https://github.com/prebid/Prebid.js
a4d1d62
Merge branch 'master' of https://github.com/prebid/Prebid.js
7215461
Merge branch 'master' of https://github.com/prebid/Prebid.js
258c555
Merge remote-tracking branch 'origin/master'
a921ac9
Merge remote-tracking branch 'remotes/remote/master'
90975d1
Merge branch 'master' of https://github.com/prebid/Prebid.js
aac67fa
Merge branch 'master' of https://github.com/prebid/Prebid.js
585993c
Merge branch 'master' of https://github.com/prebid/Prebid.js
20f5825
Merge branch 'master' of https://github.com/prebid/Prebid.js
8ce42f0
Merge branch 'master' of https://github.com/prebid/Prebid.js
253b8bb
Merge branch 'master' of https://github.com/prebid/Prebid.js
dc7fba5
Merge branch 'master' of https://github.com/prebid/Prebid.js
b93665b
Merge branch 'master' of https://github.com/prebid/Prebid.js
6e60389
Merge branch 'master' of https://github.com/prebid/Prebid.js
ce3c6c6
Merge branch 'master' of https://github.com/prebid/Prebid.js
b15a527
Merge branch 'master' of https://github.com/prebid/Prebid.js
32a6264
Merge branch 'master' of https://github.com/prebid/Prebid.js
f437bf2
Merge branch 'master' of https://github.com/prebid/Prebid.js
9d5316b
Merge branch 'master' of https://github.com/prebid/Prebid.js
1bf50d7
Merge branch 'master' of https://github.com/rubicon-project/Prebid.js
560b45b
Merge branch 'master' of https://github.com/prebid/Prebid.js
e3ddd66
changed id to use bidRequest.auctionId for all prebid server adapters
06fa386
added test for the id and source.tid values
3dc03aa
removed extra period
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is possible that publishers can pass in their own
auctionId
's intorequestBids
And in this case, we would want to be sure source.tid is always a UUID.
So after speaking with @bretg I think we should just generate a random UUID for source.tid here every time.
utils.generateUUID()
@bretg Can you comment and confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch on the pub-specified auctionId. source.tid needs to be the same even if there are multiple PBS vendors. i.e. generate a new UUID for source.tid before we start looping through the vendors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, can we move forward on this PR? I can help if needed.
cc @idettman
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@osazos - your help would be appreciated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bretg, I finally got time to work on this one.
Regarding your last comment I would like to be sure we want this behavior because it is a breaking change. Actually a large part of the process is based on the fact the
tid
is unique by Vendor. See there:Prebid.js/src/adapterManager.js
Lines 346 to 370 in 07ab54d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking at this @osazos. It would take me some time to sort out what the heck this thing is doing with "uniqueServerBidRequests", but I can say that source.tid needs to be the same for multiple PBS calls in the same auction.
So maybe we just leave "uniqueServerBidRequests" there and just generate a brand new thing to use as source.tid for the auction.