Adot Bid Adapter: add advertiser domains support; add support for openrtb video parameters on the ad unit #6876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, can you also take a look at #6512 |
|
@Giudici-a can you please add a unit test to this pr please 🙏 |
Giudici-a
force-pushed
the
adot-advertsing-domains-support
branch
from
94c55ef to
0810120
Compare
patmmccann
changed the title
|
appears to fix #6512 for adot, thanks! |
|
@ChrisHuie , i just added a test for the adomains, we are at 93.17% of coverage for our adapter ! Is it good enough for you ? @patmmccann, thank you for the review. |
|
This pull request introduces 1 alert when merging 0810120 into 6e203ea - view on LGTM.com new alerts:
|
Giudici-a
force-pushed
the
adot-advertsing-domains-support
branch
from
0810120 to
8a50925
Compare
|
@Giudici-a the test coverage is fine. Looks like there are still some errors. I think pulling upstream commits should fix that. Could you change undefined to null also because looks like lgtm is complaining about setting delay time to undefined instead of null or 0 🙏 |
Giudici-a
force-pushed
the
adot-advertsing-domains-support
branch
from
8a50925 to
4fb5eda
Compare
|
Hi @ChrisHuie, i modify the delay to avoid the lgtm complaining. But i don't understand why the tests of the ci are not working, i did the rebase on my branch with master, and the ci is still failing on test that are not on our adapter. |
|
@Giudici-a this looks fine. We have a few flaky tests that can occur from certain browsers and interacting with storage. |
ChrisHuie
approved these changes
Jun 2, 2021
AlvaroBrey
pushed a commit
to Parrable/Prebid.js
that referenced
this pull request
Jun 2, 2021
…FilterStatus' into PBID-96_requestFilterStatus * origin/parrableIdSystem/PBID-96_requestFilterStatus: (63 commits) Smaato bid adapter: Rework multi imp support (prebid#6814) Adot Bid Adapter: add the advertising domains support (prebid#6876) Update Adtelligent, Adtarget, ViewDeos adapters to support adomain (prebid#6917) LockerDome Bid Adapter: support for meta.advertiserDomains (prebid#6921) Sublime Bid Adapter : Add support for meta.advertiserDomains (prebid#6920) Brightcom Bid Adapter: use getFloor function (prebid#6918) AdYouLike Bidder: Handle advertiser domains (prebid#6916) relaido Bid Adapter: Add meta OBJ to BidResponse (prebid#6914) Jixie Bid Adapter: add support for advertiserDomains (prebid#6898) Onomagic Bid Adapter: use getFloor function (prebid#6907) Sharethrough Bid Adapter: Use getFloor module for Prebid 5.0 compliance (prebid#6874) Accept outstream renderers defined in mediatype for PBS (prebid#6896) Yieldmo Bid Adapter: read video parameters from the ad unit (prebid#6873) smartx Bid Adapter: Add support for Floors Module (prebid#6902) add support for advertiser domains (prebid#6908) Onomagic Bid Adapter: handle meta.advertiserDomains (prebid#6906) Brightcom Bid Adapter: handle meta.advertiserDomains (prebid#6905) ucfunnel Bid Adapter: add support Price Floors Module (prebid#6806) eTarget Bid Adapter: add "getMetaData" function to adapter, support for advertiserDomains (prebid#6901) AdagioBidAdapter: support priceFloors module (prebid#6867) ...
|
@ChrisHuie ok, Thanks for the review ! |
K-JBoon
added a commit
to bluebillywig/Prebid.js
that referenced
this pull request
Jun 3, 2021
* 'master' of github.com:prebid/Prebid.js: (303 commits) BridgewellBidAdapter: modify to include user ids in the bid request object (prebid#6845) GridNMBidAdapter: Use absent in video params data from mediaTypes (prebid#6817) PubMatic: For Video: bid.mediaTypes.video.mimes OR bid.params.video.mimes should be present and must be a non-empty array (prebid#6926) Increment pre version Prebid 4.42.0 Release Seedtag Bid Adapter: read video params from mediaTypes, and allow override from bidder params, support passing adomain (prebid#6888) Medianet bid adapter: MD update for video parameters. (prebid#6922) dgkeyword RTD Provider: add new real time data module (prebid#6912) Smaato bid adapter: Rework multi imp support (prebid#6814) Adot Bid Adapter: add the advertising domains support (prebid#6876) Update Adtelligent, Adtarget, ViewDeos adapters to support adomain (prebid#6917) LockerDome Bid Adapter: support for meta.advertiserDomains (prebid#6921) Sublime Bid Adapter : Add support for meta.advertiserDomains (prebid#6920) Brightcom Bid Adapter: use getFloor function (prebid#6918) AdYouLike Bidder: Handle advertiser domains (prebid#6916) relaido Bid Adapter: Add meta OBJ to BidResponse (prebid#6914) Jixie Bid Adapter: add support for advertiserDomains (prebid#6898) Onomagic Bid Adapter: use getFloor function (prebid#6907) Sharethrough Bid Adapter: Use getFloor module for Prebid 5.0 compliance (prebid#6874) Accept outstream renderers defined in mediatype for PBS (prebid#6896) ...
prebidtappx
pushed a commit
to prebidtappx/Prebid.js
that referenced
this pull request
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Change the adapter to fit with the new release by adding the support of the advertising domains.
Link to #6650