Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Richaudience Bid Adapter: add adomain support #6880

Merged
merged 7 commits into from
Jun 1, 2021
Merged

Richaudience Bid Adapter: add adomain support #6880

merged 7 commits into from
Jun 1, 2021

Conversation

richaudience
Copy link
Contributor

Type of change

  • Bugfix
  • [ x ] Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ChrisHuie ChrisHuie changed the title RichaudienceBidAdapter Add adomine for Prebid 5.0 Richaudience Bid Adapter: add adomain support May 31, 2021
@ChrisHuie
Copy link
Collaborator

@richaudience can you please throw a unit test on this please 🙏

@ChrisHuie ChrisHuie self-requested a review May 31, 2021 14:15
@ChrisHuie ChrisHuie self-assigned this May 31, 2021
@richaudience
Copy link
Contributor Author

I have added a new unit test, please check it.
Cheers

@ChrisHuie ChrisHuie merged commit 9859d19 into prebid:master Jun 1, 2021
@richaudience
Copy link
Contributor Author

Hello Guys
does this change make us compatible with 5.0 ?
I keep seeing that we are on the issue list.
#6650

Cheers

prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
* RichaudienceBidAdapter Add adomine for Prebid 5.0

* new pull

* new pull 2

* New Pull 3

* Add unit test

* New push 1

* New push 2

Co-authored-by: sgimenez <sergi.gimenez@richaudience.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants