Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integr8 Bid Adapter: add new bid adapter #6882

Merged
merged 4 commits into from Aug 3, 2021
Merged

integr8 Bid Adapter: add new bid adapter #6882

merged 4 commits into from Aug 3, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 31, 2021

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Added new adapter for integr8 adplatform

  • test parameters for validating bids
{
    bidder: 'integr8',
    params: {
        propertyId: '105109', //Required
        placementId: '846835', //Required
        data: { //Optional
            catalogs: [{
                catalogId: "699229",
                items: ["193", "4", "1"]
            }],
            inventory: {
                category: ["tech"],
                query: ["iphone 12"]
            }
        }
    }
}

@ChrisHuie ChrisHuie changed the title Added integr8 adapter integr8 Bid Adapter: add new bid adapter May 31, 2021
@harpere harpere requested a review from osazos June 3, 2021 03:59
Copy link
Collaborator

@osazos osazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ardit-baloku,

You set once your adRequest params, so if there are several adUnits using your bidder with different params, only the first value found will be set. Could you confirm it is the expected behavior?

You need to support the FloorPrices module. It is required with Prebid.js 5.x.

Regarding the video:

See https://docs.prebid.org/dev-docs/bidder-adaptor.html#supporting-video for more information.

modules/integr8BidAdapter.js Outdated Show resolved Hide resolved
modules/integr8BidAdapter.js Outdated Show resolved Hide resolved
modules/integr8BidAdapter.js Outdated Show resolved Hide resolved
modules/integr8BidAdapter.js Outdated Show resolved Hide resolved
@osazos
Copy link
Collaborator

osazos commented Jun 23, 2021

Hey there, any news @ardit-baloku ?

@ChrisHuie ChrisHuie self-requested a review July 7, 2021 08:58
@ChrisHuie ChrisHuie assigned ChrisHuie and unassigned osazos Jul 7, 2021
@ghost
Copy link
Author

ghost commented Jul 8, 2021

Hi @osazos, sorry for the late response, I was on vacation. I have resolved the comments you left on this PR.

Regarding your question if the expected behaviour was to use the first found value, the answer is yes we intended that.

I have also added support for the FloorPrices module as you requested.

Regarding video, we only used "skipTime" as a parameter for video ads and we are now fetching that from bidRequest.mediaTypes.video.skipafter, but I have left bidRequest.params.skipTime as a fallback to keep it backwards compatible. Do we need to provide a renderer outstream context? We do not plan on supporting this any time soon and would like to skip this part if possible

@osazos
Copy link
Collaborator

osazos commented Jul 26, 2021

Hi, sorry the delay.
Add a test about Floor Price would be nice, after that, all seems ok

@ghost ghost requested a review from osazos July 26, 2021 13:56
Copy link
Collaborator

@osazos osazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHuie, do you want to review it or you just self-added yourself by mistake?

@ChrisHuie
Copy link
Collaborator

@osazos Added myself just so it wasn't sitting assigned to you while it wasn't moving :) Looks good to me!

@ChrisHuie ChrisHuie assigned osazos and unassigned ChrisHuie Jul 29, 2021
@ChrisHuie ChrisHuie removed their request for review July 29, 2021 18:41
@osazos osazos merged commit b6b35af into prebid:master Aug 3, 2021
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
* Added integr8 adapter

* Double quote to single quote

* Added floor module support

* Added floor tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants