OR Bid Adapter: add support for advertiserDomains and floors module #6890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orbidder adapter: add withCredentials:true header to BidRequest and o…
Orbidder with credentials header
remove blank to trigger build ... again
adding extra line to trigger build ... again
…equest add prebid version to request
patmmccann
changed the title
ChrisHuie
approved these changes
Jun 1, 2021
prebidtappx
pushed a commit
to prebidtappx/Prebid.js
that referenced
this pull request
Nov 15, 2021
…rebid#6890) * orbidder adapter: add withCredentials:true header to BidRequest and onBidWon Requests * add blank in order to trigger build again * remove blank to trigger build ... again * adding extra line to trigger build ... again * add prebid version to request * add unit test for version parameter * add version parameter to win requests * fix comment * trigger rebuild * trigger rebuild * remove onBidWon callback from adapter * fix retrieving orbidder endpoint url from local storage * fix unit tests * use getBidFloor function for prebidv5 compatibility * fill meta.advertiserDomains from serverResponse.adomain for prebidv5 compatibility * drop eslint-disable * switch misleading expect and actual in unit test * cr: rename adomain to advertiserDomains * trigger build pipeline * trigger build pipeline Co-authored-by: Volk, Rainer <Rainer.Volk@otto.de> Co-authored-by: RainerVolk4014 <53347752+RainerVolk4014@users.noreply.github.com> Co-authored-by: siggi-otto <57615762+siggi-otto@users.noreply.github.com> Co-authored-by: Hendrik Iseke <39734979+hiseke@users.noreply.github.com> Co-authored-by: Hendrik Iseke <hendrik.iseke@gmx.de> Co-authored-by: rvolk <> Co-authored-by: Arne Schulz <Arne.Schulz@otto.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
To keep up with upcoming changes for prebid v5, this PR will: