Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waardex bid adapter: fixes for Prebid 5 #6959

Merged
merged 4 commits into from
Jun 8, 2021
Merged

Conversation

patmmccann
Copy link
Collaborator

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

This restores Waardex, fixing #6512 doc and #6465 for the bidder

@patmmccann patmmccann requested a review from ChrisHuie June 7, 2021 17:48
@patmmccann
Copy link
Collaborator Author

@ChrisHuie this restore has only two changes from master, the floor support is gone solving #6465 for waardex, the video params in the md file are moved to the ad unit, solving #6512

I am not sure why the invibes change is still listed, that is on the 5.0 branch too.

@patmmccann patmmccann changed the base branch from prebid-5.0 to master June 7, 2021 18:54
@patmmccann patmmccann changed the base branch from master to prebid-5.0 June 7, 2021 18:54
@lgtm-com
Copy link

lgtm-com bot commented Jun 7, 2021

This pull request fixes 2 alerts when merging 445238d into 4ff92fa - view on LGTM.com

fixed alerts:

  • 1 for Useless conditional
  • 1 for Client-side cross-site scripting

@ChrisHuie ChrisHuie self-assigned this Jun 8, 2021
@ChrisHuie ChrisHuie merged commit 94ad22d into prebid-5.0 Jun 8, 2021
@ChrisHuie ChrisHuie deleted the waardex-prebid5 branch June 8, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants