Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Justpremium, dspx, VisX, Yieldlab bid adapters: Add missing GVL IDs #6983

Merged
merged 4 commits into from
Jun 9, 2021

Conversation

muuki88
Copy link
Collaborator

@muuki88 muuki88 commented Jun 9, 2021

Type of change

  • Bugfix

Description of change

Add GVL IDs to some bidders that are missing it. The gdprEnforcement module otherwise blocks user syncs.

Other information

@onlsol
Copy link
Contributor

onlsol commented Jun 9, 2021

@muuki88 for DSPX the GLVID is: 602

@patmmccann
Copy link
Collaborator

for DSPX the GLVID is: 602

https://vendor-list.consensu.org/v2/vendor-list.json

You guys are 'online solution'?

@muuki88
Copy link
Collaborator Author

muuki88 commented Jun 9, 2021

I know that it was before, but ScreenOnDemand now has its own. Should I use the "old" one?

@onlsol
Copy link
Contributor

onlsol commented Jun 9, 2021

@patmmccann yes.

@muuki88 please set 602 "online solution" for our dspx adapter. it's mandatory for the technical dspx integration and user sync to be considered, in the same way as the gdprEnforcement module's check is intended.

besides, there are partnerships and integrations for SOD, independent from user sync or tech requirements, and JCA...

modules/dspxBidAdapter.js Outdated Show resolved Hide resolved
@muuki88
Copy link
Collaborator Author

muuki88 commented Jun 9, 2021

Done

@patmmccann patmmccann changed the title Add missing GVL IDs for bidders Justpremium, dspx, VisX, Yieldlab bid adapters: Add missing GVL IDs Jun 9, 2021
@patmmccann patmmccann self-assigned this Jun 9, 2021
@patmmccann patmmccann merged commit 7ab3d15 into prebid:master Jun 9, 2021
@onlsol
Copy link
Contributor

onlsol commented Jun 9, 2021

thank you.

fyi, we've also completed the GVL ID in the latest pull request (https://github.com/prebid/Prebid.js/pull/6973/files#diff-94c68527a956d2835a6a8fd243272691e8163f7555af74016bef7ab8965209bbR10) for our RADS bidder adapter besides compatibility updates for pbjs v5.

@patmmccann
Copy link
Collaborator

out of curiosity, why do you have two bidders?

@onlsol
Copy link
Contributor

onlsol commented Jun 9, 2021

we are running several very different ad servers, distinct endpoints, each of them having a different kind of feature set, formats support, partners and business models as "standalone" and separate services.

@muuki88 muuki88 deleted the add-missing-gvlids branch June 9, 2021 18:42
@muuki88
Copy link
Collaborator Author

muuki88 commented Jun 9, 2021

@onlsol , Rabby, is it you? 😂

prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
…rebid#6983)

* Add missing GVL IDs for bidders

* Remove semicolon

* Add semicolon

* Use Online Solutions Vendor ID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants