Widespace bid adapter: support for the floors module #7006
Conversation
patmmccann
changed the title
|
tyvm! |
…d.js into widespace_prebid_5_support
|
I can see some test cases failed in other adapters. But here it shows, Your tests failed on CircleCI I'm new here, What should I need to do? Please let me know! |
…d.js into widespace_prebid_5_support
There was a problem hiding this comment.
Hi @talha08,
Thanks for this PR. Change looks good but I had a few things which can be looked at.
- I don't see any unit test case covering the new
getBidFloorfunction that you wrote. - You need to submit a docs PR to change this field,
Floors Module Supporttoyes.
Do not worry about the test cases for other adapters failing on cirle ci, I see that they're passing now. Some tests are flaky which can cause the circle ci build to fail.
| let bidFloor = bid.getFloor({ | ||
| mediaType: '*', | ||
| size: '*', | ||
| currency: 'EUR' | ||
| }); |
There was a problem hiding this comment.
This can be wrapped in a try/catch block incase getFloor throws an error.
|
@talha08 Hey, just checking! I see no updates on this PR for quite a few days, do you need any help with this? |
|
@ChrisHuie Do we wanna close this PR, I haven't seen any activity on this since two months. |
|
@Fawke I will just change the assignee to me so you don't have to worry about it :) I will try and reach out. |
|
@talha08 is this pr still being worked on? Haven't heard anything in a while and we are cleaning out stale prs. If I don't hear back by Thanksgiving I will just go ahead and close this out and you can reopen again later if needed. |
Type of change
Description of change
Widespace adapter: add support for adomain and floors module for Prebid 5.
#6465
#6650