Revcontent Bid Adapter: adjusted for Price Floors Module #7093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* REVC-3691 | Prebid.js support for price floors module | Call getFloor function; test-case is added * REVC-3691 | 1 - Snippet with multi-items (#2) * REVC-3691 | Prebid.js support for price floors module | Snippet for multi-item * REVC-3691 | Prebid.js support for price floors module | Muti-item + fixed test-cases (#3) * REVC-3691 | Prebid.js support for price floors module | Fixed demo pages * REVC-3691 | Prebid.js support for price floors module | Added demo with multi-items
jcamp-revc
approved these changes
Jun 23, 2021
|
Looks like CircleCi tests weren't originally kicked off for this pr so manually kicked them off. |
ChrisHuie
changed the title
ChrisHuie
approved these changes
Jul 6, 2021
ChrisHuie
added a commit
to prebid/prebid.github.io
that referenced
this pull request
Jul 19, 2021
bretg
pushed a commit
to prebid/prebid.github.io
that referenced
this pull request
Jul 21, 2021
prebidtappx
pushed a commit
to prebidtappx/Prebid.js
that referenced
this pull request
Nov 15, 2021
* Original adapter * REVC-3691 | Prebid.js support for price floors module (#1) * REVC-3691 | Prebid.js support for price floors module | Call getFloor function; test-case is added * REVC-3691 | 1 - Snippet with multi-items (#2) * REVC-3691 | Prebid.js support for price floors module | Snippet for multi-item * REVC-3691 | Prebid.js support for price floors module | Muti-item + fixed test-cases (#3) * REVC-3691 | Prebid.js support for price floors module | Fixed demo pages * REVC-3691 | Prebid.js support for price floors module | Added demo with multi-items * manually kick off circleci tests Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Existing
revcontentBidAdapterwas adjusted to comply with Price Floors Module.revcontentBidAdapter.mdis already available in the repo.