Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merkle userid module: storing session data and domain #7100

Merged
merged 4 commits into from
Jul 8, 2021

Conversation

SKOCHERI
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@lgtm-com
Copy link

lgtm-com bot commented Jun 25, 2021

This pull request introduces 1 alert when merging 2f526b6 into e39cb75 - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

modules/merkleIdSystem.js Outdated Show resolved Hide resolved
modules/merkleIdSystem.js Outdated Show resolved Hide resolved
@SKOCHERI SKOCHERI changed the title Merkle userid module: storing session data Merkle userid module: storing session data and domain Jun 30, 2021
@jdwieland8282
Copy link
Member

@msm0504 mind taking a look at this? @SKOCHERI made the requested changes and I'd like to merge this

@msm0504 msm0504 merged commit ee21999 into prebid:master Jul 8, 2021
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
* Merkle userid module: storing session data

* Merkle: Setting session data

* Fixing review comments

* Updating to get the root domain if “sv_domain” is not configured

Co-authored-by: skocheri <skocheri@rubiconproject.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants