Sortable Bid Adapter: update to comply with Prebid 5.x #7157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the price floors module. Remove floor size map logic. Add advertiserDomains to bid responses. Update unit tests.
|
I seem to be getting random build failures that are unrelated to my PR changes. I had tests failing, rebased, and now there's a different test failing. Can someone with permissions please re-run the build? |
ChrisHuie
changed the title
ChrisHuie
approved these changes
Jul 9, 2021
ChrisHuie
added a commit
to prebid/prebid.github.io
that referenced
this pull request
Jul 19, 2021
bretg
pushed a commit
to prebid/prebid.github.io
that referenced
this pull request
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Updates to support new Prebid 5.x requirements.
Other information
#5966 -> Prebid 5.0
#6650 -> 5.x issue for advertiserDomain
#6465 -> 5.x issue for floors module
The first commit re-introduces the bid adapter as it was in 4.x.