Sonobi bid adapter: add support for floor module #7206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
approved these changes
Jul 22, 2021
patmmccann
changed the title
patmmccann
reviewed
Jul 22, 2021
| if (isPlainObject(floor) && !isNaN(floor.floor) && floor.currency === 'USD') { | ||
| return floor.floor; | ||
| } | ||
| return ''; |
There was a problem hiding this comment.
this always returns something, making the else in the wrapping function redundant i think?
prebidtappx
pushed a commit
to prebidtappx/Prebid.js
that referenced
this pull request
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Sonobi Bidder Adapter will now try to first look for any floors defined using the floor module before trying to pull from its bidder params.