Gulp Build: fix installed gulp modules returning placeholder value #7304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempted fix for issue => #7287
ChrisHuie
changed the title
ChrisHuie
changed the title
ChrisHuie
changed the title
ChrisHuie
added
the
needs 2nd review
There was a problem hiding this comment.
When I do (taken from readme):
gulp build --modules=openxBidAdapter,rubiconBidAdapter,sovrnBidAdapter
My prebid.js is built with following piece of code:
A.installedModules=[""openxBidAdapter","rubiconBidAdapter","sovrnBidAdapter""]
Then, when I try to load that .js in some html page it crashes because of duplicate "".
Doing the same command on master branch it looks fine. Here is what I get on master:
E.installedModules=["openxBidAdapter","rubiconBidAdapter","sovrnBidAdapter"]
|
@FilipStamenkovic thank you. Let me check what is going on with the extra quotes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change regex to specific string for attempted fix on issue => #7287