LuponMedia: add bidfloor support #7458

adxpremium · 2021-09-23T10:20:20Z

Type of change

Bugfix
[ x] Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
[x ] Other

Description of change

Prebid-js v5.X support

support v5

ChrisHuie · 2021-10-01T13:03:30Z

modules/luponmediaBidAdapter.js

+    }
+    bidFloor = typeof floorInfo === 'object' && floorInfo.currency === 'USD' && !isNaN(parseInt(floorInfo.floor)) ? parseFloat(floorInfo.floor) : undefined;
+  } else {
+    bidFloor = parseFloat(utils.deepAccess(bidRequest, 'params.floor'));


We have made it so that all adapters now only import the needed "utils" functions so you no longer need utils. in the root of the function call anymore. That is the code conflict (at least in the main code, not sure what the conflict in the testing file is).

ChrisHuie · 2021-10-01T13:06:05Z

@adxpremium I am not sure why the testing all the sudden stopped running on this pr?? Looks like both CircleCI and LGTM did noot run for the last 2 commits

import only needed utils functions

adxpremium · 2021-10-13T08:31:19Z

@ChrisHuie we have fixed the utils part. Checks are failing again. Could you please check what needs to be done? Thanks

ChrisHuie · 2021-10-14T13:20:10Z

@adxpremium your current branch is really far behind master. Pulling all prs from master should fix this because this adapter was removed in 5.0 (current version). This should add the whole adapter back into version 5.

per pr -> prebid/Prebid.js#7458

* Lupon Media Bid Adapter: update prebid 5 complianc per pr -> prebid/Prebid.js#7458 * update not in 5.x

* Create generic bidder documentation (#3413) * Fixed typo * Added Generic bidder docs * iProm Bid Adapter: update versions included (#3420) per pr -> prebid/Prebid.js#7700 * add first-party data support to beachfront doc (#3418) Co-authored-by: John Salis <john@beachfront.com> * new bidderSettings field - allowZeroCpmBids (#3414) * add native support (#3409) * Missena Bid Adapter: update with prebid compliance (#3408) * Missena Bid Adapter: update with prebid compliance per pr -> prebid/Prebid.js#7648 * update versioning to include not in 5.x * Add Intersection RTD Provider docs (#3407) * upd docs * Update dev-docs/modules/intersectionRtdProvider.md Co-authored-by: Andrew <fowler446@users.noreply.github.com> * Limelight Digital Bid Adapter: Add optional Publisher ID field (#3405) * smartx Bid Adapter: refactor descriptions and adding "visibilityThreshold" (#3403) * initial commit * adjustments * adjustments * adjustments * typo, further adjustments * removed userIds and schain support * Added optionals to outstream and made formatting * Update smartx.md minor edits for clarification and readability. * adjusted outstream_options * remove outstream_function, added pbjs_version_notes * bugfix outstream options for default outstream renderer configuration * refactor descriptions and adding "visibilityThreshold" Co-authored-by: Gino <adtech@smartclip.tv> Co-authored-by: Jean Stemp <38964447+jeanstemp@users.noreply.github.com> * VIS.X: update docs (#3402) Update the VIS.X documentation under the latest adapter changes. * Adplus bid adapter doc added (#3389) * Adplus bid adapter doc added * Quotes added to string arguments Co-authored-by: TCCDENIZ <cansin.deniz@turkcell.com.tr> * Created gb_xandr.md docs (#3384) * Create gb_xandr.md * renamed the file * Update dev-docs/bidders/goldbach.md Co-authored-by: Andrew <fowler446@users.noreply.github.com> * Lupon Media Bid Adapter: update prebid 5 complianc (#3347) * Lupon Media Bid Adapter: update prebid 5 complianc per pr -> prebid/Prebid.js#7458 * update not in 5.x * Update userId.md (#2788) * gpid docs (#3421) * fixed broken link (#3423) * fixed floors doc issue (#3425) * added api version note (#3434) * Interstitials (#2869) * removed sizes from RP bid params * added interstitial page and config to adUnit * interstitial page corrections * Update InterstitialAds.md * Update InterstitialAds.md * modified sidebar link * changed interstitials file name and reference * wordsmithing Co-authored-by: MartianTribe <steve@martiantribe.com> Co-authored-by: bretg <bgorsline@gmail.com> * added vendor-specific flag (#3437) * added KVP reference Co-authored-by: Alex Maltsev <and1sscsgo@gmail.com> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: John Salis <jsalis531@gmail.com> Co-authored-by: John Salis <john@beachfront.com> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com> Co-authored-by: AdmixerTech <35560933+AdmixerTech@users.noreply.github.com> Co-authored-by: Andrew <fowler446@users.noreply.github.com> Co-authored-by: Ilya Medvedev <medved55rus@gmail.com> Co-authored-by: Skylinar <53079123+Skylinar@users.noreply.github.com> Co-authored-by: Gino <adtech@smartclip.tv> Co-authored-by: Jean Stemp <38964447+jeanstemp@users.noreply.github.com> Co-authored-by: rrelict <rrelict@users.noreply.github.com> Co-authored-by: cnsndnz <82813495+cnsndnz@users.noreply.github.com> Co-authored-by: TCCDENIZ <cansin.deniz@turkcell.com.tr> Co-authored-by: dveljovicTX <69788339+dveljovicTX@users.noreply.github.com> Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Bryan Szekely <49168870+bszekely1@users.noreply.github.com> Co-authored-by: MartianTribe <steve@martiantribe.com>

* Create generic bidder documentation (#3413) * Fixed typo * Added Generic bidder docs * iProm Bid Adapter: update versions included (#3420) per pr -> prebid/Prebid.js#7700 * add first-party data support to beachfront doc (#3418) Co-authored-by: John Salis <john@beachfront.com> * new bidderSettings field - allowZeroCpmBids (#3414) * add native support (#3409) * Missena Bid Adapter: update with prebid compliance (#3408) * Missena Bid Adapter: update with prebid compliance per pr -> prebid/Prebid.js#7648 * update versioning to include not in 5.x * Add Intersection RTD Provider docs (#3407) * upd docs * Update dev-docs/modules/intersectionRtdProvider.md Co-authored-by: Andrew <fowler446@users.noreply.github.com> * Limelight Digital Bid Adapter: Add optional Publisher ID field (#3405) * smartx Bid Adapter: refactor descriptions and adding "visibilityThreshold" (#3403) * initial commit * adjustments * adjustments * adjustments * typo, further adjustments * removed userIds and schain support * Added optionals to outstream and made formatting * Update smartx.md minor edits for clarification and readability. * adjusted outstream_options * remove outstream_function, added pbjs_version_notes * bugfix outstream options for default outstream renderer configuration * refactor descriptions and adding "visibilityThreshold" Co-authored-by: Gino <adtech@smartclip.tv> Co-authored-by: Jean Stemp <38964447+jeanstemp@users.noreply.github.com> * VIS.X: update docs (#3402) Update the VIS.X documentation under the latest adapter changes. * Adplus bid adapter doc added (#3389) * Adplus bid adapter doc added * Quotes added to string arguments Co-authored-by: TCCDENIZ <cansin.deniz@turkcell.com.tr> * Created gb_xandr.md docs (#3384) * Create gb_xandr.md * renamed the file * Update dev-docs/bidders/goldbach.md Co-authored-by: Andrew <fowler446@users.noreply.github.com> * Lupon Media Bid Adapter: update prebid 5 complianc (#3347) * Lupon Media Bid Adapter: update prebid 5 complianc per pr -> prebid/Prebid.js#7458 * update not in 5.x * Update userId.md (#2788) * gpid docs (#3421) * fixed broken link (#3423) * fixed floors doc issue (#3425) * added api version note (#3434) * Interstitials (#2869) * removed sizes from RP bid params * added interstitial page and config to adUnit * interstitial page corrections * Update InterstitialAds.md * Update InterstitialAds.md * modified sidebar link * changed interstitials file name and reference * wordsmithing Co-authored-by: MartianTribe <steve@martiantribe.com> Co-authored-by: bretg <bgorsline@gmail.com> * added vendor-specific flag (#3437) * added KVP reference * review comments * adding link to related reading Co-authored-by: Alex Maltsev <and1sscsgo@gmail.com> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: John Salis <jsalis531@gmail.com> Co-authored-by: John Salis <john@beachfront.com> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com> Co-authored-by: AdmixerTech <35560933+AdmixerTech@users.noreply.github.com> Co-authored-by: Andrew <fowler446@users.noreply.github.com> Co-authored-by: Ilya Medvedev <medved55rus@gmail.com> Co-authored-by: Skylinar <53079123+Skylinar@users.noreply.github.com> Co-authored-by: Gino <adtech@smartclip.tv> Co-authored-by: Jean Stemp <38964447+jeanstemp@users.noreply.github.com> Co-authored-by: rrelict <rrelict@users.noreply.github.com> Co-authored-by: cnsndnz <82813495+cnsndnz@users.noreply.github.com> Co-authored-by: TCCDENIZ <cansin.deniz@turkcell.com.tr> Co-authored-by: dveljovicTX <69788339+dveljovicTX@users.noreply.github.com> Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Bryan Szekely <49168870+bszekely1@users.noreply.github.com> Co-authored-by: MartianTribe <steve@martiantribe.com>

adxpremium and others added 10 commits August 31, 2020 01:08

added onBidWon event

a6ad1bc

luponmedia onBidWon event + test

07015ae

luponmedia onbidwon event + unit test

93e6946

luponmedia onbidwon event + test

fae96ba

luponmedia onbidwon + unit testing

86036c0

luponmedia onbidwon event + unit tests

1a7871c

luponmedia onbidwon event ajax

4bb2de4

package-log revert

474b615

support v5

eb6d060

Merge pull request #1 from adxpremium/luponmedia-upgrade

22bc49a

support v5

ChrisHuie self-requested a review September 23, 2021 12:44

ChrisHuie self-assigned this Sep 23, 2021

ChrisHuie added do not merge maintenance and removed do not merge labels Sep 23, 2021

ChrisHuie reviewed Oct 1, 2021

View reviewed changes

ChrisHuie changed the title ~~LuponMedia - v5.X support~~ LuponMedia: add bidfloor and adomain support Oct 1, 2021

ChrisHuie changed the title ~~LuponMedia: add bidfloor and adomain support~~ LuponMedia: add bidfloor support Oct 1, 2021

mehog and others added 2 commits October 6, 2021 21:59

import only needed utils functions

83a02e9

Merge pull request #2 from adxpremium/luponmedia-upgrade

5166a76

import only needed utils functions

ChrisHuie added a commit to prebid/prebid.github.io that referenced this pull request Oct 14, 2021

Lupon Media Bid Adapter: update prebid 5 complianc

b451135

per pr -> prebid/Prebid.js#7458

ChrisHuie mentioned this pull request Oct 14, 2021

Lupon Media Bid Adapter: update prebid 5 complianc prebid/prebid.github.io#3347

Merged

adxpremium closed this Oct 19, 2021

fowler446 pushed a commit to prebid/prebid.github.io that referenced this pull request Nov 19, 2021

Lupon Media Bid Adapter: update prebid 5 complianc (#3347)

0bc0a20

* Lupon Media Bid Adapter: update prebid 5 complianc per pr -> prebid/Prebid.js#7458 * update not in 5.x

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LuponMedia: add bidfloor support #7458

LuponMedia: add bidfloor support #7458

adxpremium commented Sep 23, 2021

ChrisHuie Oct 1, 2021 •

edited

Loading

ChrisHuie commented Oct 1, 2021

adxpremium commented Oct 13, 2021

ChrisHuie commented Oct 14, 2021

LuponMedia: add bidfloor support #7458

LuponMedia: add bidfloor support #7458

Conversation

adxpremium commented Sep 23, 2021

Type of change

Description of change

ChrisHuie Oct 1, 2021 • edited Loading

Choose a reason for hiding this comment

ChrisHuie commented Oct 1, 2021

adxpremium commented Oct 13, 2021

ChrisHuie commented Oct 14, 2021

ChrisHuie Oct 1, 2021 •

edited

Loading