Prebid Server Bid Adapter: auctionId to $.id UUID to $.source.tid + mergeDeep extPrebid #7585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
robertrmartinez
changed the title
…BidAdapter-sourceTid
|
Only failed test was because of https://github.com/prebid/Prebid.js/pull/7594/files#r734688687 |
ChrisHuie
changed the title
ChrisHuie
approved these changes
Oct 26, 2021
Fawke
approved these changes
Nov 2, 2021
|
Did we want to backport this one? |
cpabst
pushed a commit
to sovrn/Prebid.js
that referenced
this pull request
Jan 10, 2022
…ergeDeep extPrebid (prebid#7585) * sourceTid * revert unique to tid cuz easier * deep merge extprebid * add tests for changes * .length duh * test was incorrect * no longer let this val be tid as it is not representitive * fix test
This was referenced Jun 23, 2022
10 tasks
This was referenced Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Retry of #6836
Implements #6563
We will now pass
auctionIdinto$.idPrebid's
auctionIdis a UUID - UNLESS a pub passes in their own auctionId.This is not okay since PBS needs
$.source.tidto be a UUIDAlso it needs to be the SAME VALUE for every PBS request for a given auction (IE Multiple PBS Scenarios)
So we generate a UUID and assign it to each bidRequest to PBS as
tidSo, for all PBS requests for a given auction, we should see the same exact
$.idand the same exact$.source.tid(which should be different themselves)Like so:
extPrebid Fix
Also in this PR is a fix for #7457
Which just deep merges extPrebid instead of shallow merge.