Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

showheroes-bs Bid Adapter: fix for outstream render #7604

Merged
merged 27 commits into from
Nov 18, 2021
Merged

showheroes-bs Bid Adapter: fix for outstream render #7604

Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
d0b644d
add ShowHeroes Adapter
vadim-mazzherin Apr 10, 2019
b6c0154
Merge remote-tracking branch 'upstream/master'
vadim-mazzherin Sep 23, 2019
bfcdb91
ShowHeroes adapter - expanded outstream support
vadim-mazzherin Sep 23, 2019
c2e4686
Revert "ShowHeroes adapter - expanded outstream support"
vadim-mazzherin Sep 23, 2019
6c57d09
ShowHeroes adapter - expanded outstream support
vadim-mazzherin Sep 23, 2019
f10b01f
Merge branch 'master' of https://github.com/prebid/Prebid.js
veranevera Oct 1, 2019
6b36284
ShowHeroes adapter - fixes (#4222)
veranevera Oct 1, 2019
2f7f6e6
Merge branch 'master' of https://github.com/prebid/Prebid.js
veranevera Oct 7, 2019
c701851
ShowHeroes adapter - banner and outstream fixes (#4222)
veranevera Oct 7, 2019
3ea3260
Merge branch 'master' of https://github.com/prebid/Prebid.js
veranevera Oct 8, 2019
02ce519
ShowHeroes adapter - description and outstream changes (#4222)
veranevera Oct 8, 2019
041268c
ShowHeroes adapter - increase test coverage and small fix
vadim-mazzherin Oct 10, 2019
fa9d95c
Merge remote-tracking branch 'upstream/master'
vadim-mazzherin Oct 10, 2019
84009c7
Merge remote-tracking branch 'upstream/master'
vadim-mazzherin Dec 2, 2019
e11820c
ShowHeroes Adapter - naming convention issue
vadim-mazzherin Dec 3, 2019
94b1a53
Merge remote-tracking branch 'upstream/master'
vadim-mazzherin Dec 3, 2019
5319b37
Merge remote-tracking branch 'upstream/master'
vadim-mazzherin Mar 24, 2020
45b3714
Mixed AdUnits declaration support
vadim-mazzherin Apr 7, 2020
2e06464
ITDEV-4723 PrebidJS adapter support with SupplyChain module object
h2p4x8 Apr 30, 2020
09c158f
ITDEV-4723 Fix tests
vadim-mazzherin Apr 30, 2020
f039423
ITDEV-4723 New entry point
vadim-mazzherin May 4, 2020
942a645
Merge remote-tracking branch 'upstream/master'
vadim-mazzherin May 5, 2020
e31698d
Merge remote-tracking branch 'upstream/master'
vadim-mazzherin Jul 11, 2021
1315c9e
showheroes-bsBidAdapter: Add support for advertiserDomains
vadim-mazzherin Jul 12, 2021
ae0d73d
showheroes-bsBidAdapter: hotfix for outstream render
vadim-mazzherin Oct 20, 2021
2270649
Merge remote-tracking branch 'upstream/master'
vadim-mazzherin Oct 20, 2021
09da82a
showheroes-bsBidAdapter: update renderer url
vadim-mazzherin Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion modules/showheroes-bsBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ export const spec = {

return {
type: streamType,
adUnitCode: bid.adUnitCode,
bidId: bid.bidId,
mediaType: type,
context: context,
Expand Down Expand Up @@ -159,6 +160,7 @@ function createBids(bidRes, reqData) {
let bidUnit = {};
bidUnit.cpm = bid.cpm;
bidUnit.requestId = bid.bidId;
bidUnit.adUnitCode = reqBid.adUnitCode;
bidUnit.currency = bid.currency;
bidUnit.mediaType = bid.mediaType || VIDEO;
bidUnit.ttl = TTL;
Expand All @@ -183,7 +185,8 @@ function createBids(bidRes, reqData) {
} else if (bid.context === 'outstream') {
const renderer = Renderer.install({
id: bid.bidId,
url: '//',
url: 'https://static.showheroes.com/renderer.js',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing any data in this file, is that intended?

adUnitCode: reqBid.adUnitCode,
config: {
playerId: reqBid.playerId,
width: bid.size.width,
Expand Down