-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yieldlab Bid Adapter: add support for native mediatype #7609
Conversation
This is awesome news. No workarounds anymore. What I don't understand is if this supports Multiformat? |
Hi @muuki88 , for now it supports native image. |
Thanks for your feedback 🤗 @alex-ylb My question was what happens if banner and native are requested at the same time. |
Hi @muuki88 I wanna try to give you an answer to your questions. As far as I can understand it from the docs, by multi-format you mean that there is more than one media type defined per ad unit. That is possible for the Yieldlab adapter. However, to make a configuration like really support different media types it is additionally required to set up the This brings me to the second question. E.g. banner and native can be requested "at the same time", if the bids section is configured as described above. However, one bid cannot be banner or native at the same time as we would either return a result for either of that. Of course it would work to have multiple results but one bid would always only be of one certain type. Does that answer your questions? Please ping us again if anything doesn't make sense. |
That's super helpful @kippsterr 🙇♂️ 💡
This could look something like this const adUnit = {
code: 'ad-slot-1',
mediaTypes: {
banner: {
sizes: [ [ 300, 250 ] ]
},
native: {
// native config
}
},
bids: [
// banner ad slot
{ bidder: 'yieldlab', params: { adslotId: '1234', supplyId: '42' } },
// native ad slot
{ bidder: 'yieldlab', params: { adslotId: '2345', supplyId: '42' } }
]
}; It would be amazing if this information could be made available in the docs PR as well ❤️ |
Yes, that looks perfectly right. To be honest, we do have revisiting the whole documentation part - for the adapter and for the website - on our list anyway. But I agree, that we should at least put the bare minimum for the multi-format part right now and can then still add more detail info later. |
Object doesn't support property or method 'find' in IE 11
Add Yieldlab multi-format documentation
Hi @muuki88, we've added the multi-format documentation and also fixed the not so cross browser direct use of And can I ask you a question? Do you know why there's this constant amount of randomly failing Browserstack tests? It seems like whenever we fetch the latest upstream changes something else goes wrong and this PR is never going to get green. |
Amazing 🎉 🎉 Thanks a lot.
I'm not too familiar with the browserstack tests, but the failing test seems that is has absolutely nothing to do with your changes. @ChrisHuie can you shed some light on this?
|
@kippsterr rerunning the circleCI pipeline usually helps in this situation. |
Thanks! @aleksatr
It seems like we cannot do that on our own, can we? We would just ping you in such cases then. Or did we miss something in the usual workflow which lead to the fact that we're not able to do it? Alright, so whenever you're fine with the PR and all necessary approvals are given we're also fine with having the PR merged at any time. Thank you guys for your support 🙇♂️ |
@kippsterr to be honest I'm not sure, try to access https://app.circleci.com/pipelines/github/prebid/Prebid.js/8842/workflows/9d731327-92b0-42c9-a0e8-4eb7dd073f25/jobs/19097 (assuming you can login to circleCI with your github account) |
* YL-3989: Accept NATIVE yieldprobe response (#2) * YL-3989: Accept NATIVE response * Fix: 'utils' is not defined no-undef * trigger GitHub actions * Add multi-format example to the Yieldlab bidder documentation * Reformat code * Fix: Object doesn't support 'find' Object doesn't support property or method 'find' in IE 11 * trigger GitHub actions * Chore:Replace `filter` by `find` from ..array/find.js * Fix typo Co-authored-by: Christoph <29540638+kippsterr@users.noreply.github.com>
Type of change
Description of change
In this change the yieldlabBidAdapter adapter adds support for Native mediatype
The second PR on the docs repo at: prebid/prebid.github.io#3363