MerkleID: add check for typof configParams.endpoint on extendId #7611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHuie
changed the title
|
@Yehuda64 can you please remove your package.lock file from this pr? |
|
I pushed a commit not too long ago that deleted the |
|
@Yehuda64 yeah. You just need to remove it from tracking files in git. Right now you are actually deleting out the entire package-lock file from the project if that makes since? |
|
Yup yup! That makes sense 😄 |
gwhigs
approved these changes
Oct 27, 2021
cpabst
pushed a commit
to sovrn/Prebid.js
that referenced
this pull request
Jan 10, 2022
…id#7611) * Chore: Added check for typof configParams.endpoint on extendId * Chore: Fixed various test issues * Chore: Removed stray console.log Console Log * Removed Package-lock.json * Chore: Added back original package-lock.json
10 tasks
This was referenced Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
We received a report where a request from the the Merkle module is resulting in a bad network request. It seems to be a bug in the module code. Our solution was to assign the default value of our MerkleId config object endpoint to ID_URL, and log a warning saying that "merkleId submodule endpoint string is not defined". Additionally a test was added to go with this change.
Other information
This is related to our ADT-300