Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Sspbc Bid Adapter: update version and bugfixes" #7654

Closed
wants to merge 1 commit into from

Conversation

patmmccann
Copy link
Collaborator

@patmmccann patmmccann commented Nov 2, 2021

Reverts #7584 due to failing CI tests

update - the revert fails tests too; maybe this is the wrong path

@Rothalack
Copy link
Collaborator

Rothalack commented Nov 2, 2021

What I've started doing in cases like this is trust the original circleci test of the PR itself. If that passes, I feel pretty confident. Then when I do the master merge, I give the circleci build a couple tries and verify that any errors occurring are not related to the changes in the PR. I try not to spam out circleci builds over and over and clog up the system. Maybe I should just keep retrying until it passes.

That noted, I do not see any errors related to the SSPBC update or files.

Is it possible circleci doesn't have enough resources to run the tests anymore? This is something I've noticed recently in local testing, I have to add to my gulp command with enough RAM:
NODE_OPTIONS=--max-old-space-size=7168 gulp review-start
Just a thought.

@patmmccann
Copy link
Collaborator Author

That is really interesting @Rothalack

The revert didn't pass the test either, so I am not sure what is the source of these failing adapter manager size tests. Usually any failing tests are timeouts from an analytics call not properly mocked or something.

@patmmccann patmmccann closed this Nov 2, 2021
@patmmccann patmmccann deleted the revert-7584-sspbc-5.3 branch November 2, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants