Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SharedID module: update tests to assert on behavior rather than logs #7738

Merged
merged 1 commit into from
Nov 18, 2021
Merged

SharedID module: update tests to assert on behavior rather than logs #7738

merged 1 commit into from
Nov 18, 2021

Commits on Nov 18, 2021

  1. SharedID module: update tests to assert on behavior rather than logs 

    Update tests that fail spuriously: prebid#7355
I was not able to reproduce the failures, but in debugging I ruled out the possibility of module loading order and I believe the most likely culprit is other tests asynchronously calling `utils.logInfo` that sometimes happen in-between these tests' setup and assertions.

This may not be the real issue, but IMO testing log messages makes little sense anyway, so I updated them to test the actual SOT behavior.
    @dgirardi
    dgirardi committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    cc5d442 View commit details
    Browse the repository at this point in the history