Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinesso ID: fix endpoint query param #7748

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

SKOCHERI
Copy link
Contributor

@SKOCHERI SKOCHERI commented Nov 22, 2021

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ChrisHuie ChrisHuie changed the title Fixing kinesso endpoint query param Kinesso ID: fix endpoint query param Nov 23, 2021
@ChrisHuie
Copy link
Collaborator

ChrisHuie commented Nov 23, 2021

merged #7743 so this is a duplicate pr @SKOCHERI

@ChrisHuie ChrisHuie closed this Nov 23, 2021
@robertrmartinez
Copy link
Collaborator

@ChrisHuie

This was meant to be on the 5.X legacy branch

@jsnellbaker jsnellbaker reopened this Dec 1, 2021
@jsnellbaker
Copy link
Collaborator

jsnellbaker commented Dec 1, 2021

Reopening this PR based on latest comments from @robertrmartinez

If this should be added for the legacy branch - please reconfirm so we can merge.

If it is no longer needed and should be closed - please also confirm, so we can put back to the proper state.

Thanks.

@patmmccann
Copy link
Collaborator

@jsnellbaker appears this bug fix is definitely useful in legacy

@jsnellbaker jsnellbaker merged commit ac9da94 into prebid:5.20.x-legacy Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants