Colossus Bid Adapter: fix validator

modules/colossussspBidAdapter.js

@@ -1,6 +1,7 @@
 import { getWindowTop, deepAccess, logMessage } from '../src/utils.js';
 import { registerBidder } from '../src/adapters/bidderFactory.js';
 import { BANNER, NATIVE, VIDEO } from '../src/mediaTypes.js';
+import { ajax } from '../src/ajax.js';
 
 const BIDDER_CODE = 'colossusssp';
 const G_URL = 'https://colossusssp.com/?c=o&m=multi';
@@ -46,7 +47,10 @@ export const spec = {
  * @return boolean True if this is a valid bid, and false otherwise.
  */
  isBidRequestValid: (bid) => {
- return Boolean(bid.bidId && bid.params && !isNaN(bid.params.placement_id));
+ const validPlacamentId = bid.params && !isNaN(bid.params.placement_id);
+ const validGroupId = bid.params && !isNaN(bid.params.group_id);
+
+ return Boolean(bid.bidId && (validPlacamentId || validGroupId));
  },
 
  /**
@@ -60,13 +64,13 @@ export const spec = {
  const location = winTop.location;
  let placements = [];
  let request = {
- 'deviceWidth': winTop.screen.width,
- 'deviceHeight': winTop.screen.height,
- 'language': (navigator && navigator.language) ? navigator.language : '',
- 'secure': location.protocol === 'https:' ? 1 : 0,
- 'host': location.host,
- 'page': location.pathname,
- 'placements': placements,
+ deviceWidth: winTop.screen.width,
+ deviceHeight: winTop.screen.height,
+ language: (navigator && navigator.language) ? navigator.language : '',
+ secure: location.protocol === 'https:' ? 1 : 0,
+ host: location.host,
+ page: location.pathname,
+ placements: placements,
  };
 
  if (bidderRequest) {
@@ -84,6 +88,7 @@ export const spec = {
  let traff = bid.params.traffic || BANNER
  let placement = {
  placementId: bid.params.placement_id,
+ groupId: bid.params.group_id,
  bidId: bid.bidId,
  sizes: bid.mediaTypes[traff].sizes,
  traffic: traff,
@@ -175,6 +180,12 @@ export const spec = {
  type: 'image',
  url: G_URL_SYNC
  }];
+ },
+
+ onBidWon: (bid) => {
+ if (bid.nurl) {
+ ajax(bid.nurl, null);
+ }
  }
 };
 

modules/colossussspBidAdapter.md

@@ -26,5 +26,19 @@ Module that connects to Colossus SSP demand sources
  traffic: 'banner'
  }
  }]
- ];
+ }, {
+ code: 'placementid_1',
+ mediaTypes: {
+ banner: {
+ sizes: [[300, 250], [300,600]]
+ }
+ },
+ bids: [{
+ bidder: 'colossusssp',
+ params: {
+ group_id: 0,
+ traffic: 'banner'
+ }
+ }]
+ }];
 ```

test/spec/modules/colossussspBidAdapter_spec.js

@@ -7,7 +7,8 @@ describe('ColossussspAdapter', function () {
  bidder: 'colossusssp',
  bidderRequestId: '145e1d6a7837c9',
  params: {
- placement_id: 0
+ placement_id: 0,
+ group_id: 0
  },
  placementCode: 'placementid_0',
  auctionId: '74f78609-a92d-4cf1-869f-1b244bbfb5d2',
@@ -60,6 +61,7 @@ describe('ColossussspAdapter', function () {
  });
  it('Should return false when placement_id is not a number', function () {
  bid.params.placement_id = 'aaa';
+ delete bid.params.group_id;
  expect(spec.isBidRequestValid(bid)).to.be.false;
  });
  });
@@ -95,9 +97,10 @@ describe('ColossussspAdapter', function () {
  let placements = data['placements'];
  for (let i = 0; i < placements.length; i++) {
  let placement = placements[i];
- expect(placement).to.have.all.keys('placementId', 'eids', 'bidId', 'traffic', 'sizes', 'schain', 'floor', 'gpid');
+ expect(placement).to.have.all.keys('placementId', 'groupId', 'eids', 'bidId', 'traffic', 'sizes', 'schain', 'floor', 'gpid');
  expect(placement.schain).to.be.an('object')
  expect(placement.placementId).to.be.a('number');
+ expect(placement.groupId).to.be.a('number');
  expect(placement.bidId).to.be.a('string');
  expect(placement.traffic).to.be.a('string');
  expect(placement.sizes).to.be.an('array');
@@ -186,6 +189,15 @@ describe('ColossussspAdapter', function () {
  });
  });
 
+ describe('onBidWon', function () {
+ it('should make an ajax call', function () {
+ const bid = {
+ nurl: 'http://example.com/win',
+ };
+ expect(spec.onBidWon(bid)).to.equals(undefined);
+ });
+ })
+
  describe('getUserSyncs', function () {
  let userSync = spec.getUserSyncs();
  it('Returns valid URL and type', function () {