Build system: upgrade webpack #7935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…js' / import events from 'events.js' return different objects, which is a problem for stubbing)
|
This pull request fixes 1 alert when merging b89d5b3 into 4183f5d - view on LGTM.com fixed alerts:
|
|
Converting this back to draft because I believe |
|
Reopening this for review. I was concerned about situations of the kind described here: #7936 (comment) That is an unused export for the 'prebid-core' webpack entry, so I was expecting it to get removed after this update (and unit tests wouldn't notice since they use different entries). Turns out it isn't, and it may be connected to the For the moment I think it makes sense to have this PR focused only on the upgrade, possibly following up with tweaking tree shaking config. |
robertrmartinez
approved these changes
Jan 19, 2022
|
@dgirardi I'm not sure off-hand about the test-only behavior. But I wanted to highlight something. When I was testing some gulp commands with this PR, I was seeing the following error from webpack: This occurred when I was using an older version of node (8.9.4) - which is what the build server we use for releases is currently configured to use. When I use a higher version of node, the build command works fine. Is there any config setting that could be used within webpack to help support the older version? Or does the upgrade to webpack 5 require the higher node? |
|
@jsnellbaker from https://webpack.js.org/migrate/5:
|
|
Can we please hold off on merging this then? If it goes through it will interrupt/block the release processes. We're trying on our end to update some things, but it's going to take time. |
Closed
2 tasks
|
This pull request fixes 1 alert when merging 841311a into 436f8d7 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 22a7b0c into e2eb950 - view on LGTM.com fixed alerts:
|
jsnellbaker
approved these changes
Mar 8, 2022
|
@robertrmartinez can you sign off on changes that have occurred after your review? |
|
This pull request fixes 1 alert when merging 9f42bea into 4e0bd23 - view on LGTM.com fixed alerts:
|
ChrisHuie
approved these changes
Mar 17, 2022
dgirardi
added a commit
to dgirardi/Prebid.js
that referenced
this pull request
Mar 17, 2022
1 task
dgirardi
added a commit
that referenced
this pull request
Mar 18, 2022
EugeneVigonny
added a commit
to Insticator/Prebid.js
that referenced
this pull request
May 23, 2022
* orbidderBidAdapter: add unit test for price floor module (#8044) * Update 33acrossBidAdapter.js * Update smaatoBidAdapter.js * zeta_global_sspBidAdapter: remove devicetype (#8098) Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com> * Revert "Merge branch 'patmmccann-patch-1' into master" (#8103) This reverts commit bd2e9f1cb4c9dac10bfa85f5951083b79f5e2fa9, reversing changes made to 9c0975a937ea55e36a290092c55b7fd0d494fb95. * 33across, Smaato, OneVideo, & Sharethrough Bid Adapters: Add GVLID (#8104) * Update 33acrossBidAdapter.js * Update smaatoBidAdapter.js * Update sharethroughBidAdapter.js * Update oneVideoBidAdapter.js * Medianet Analytics Adapter: Multiple bidResponse with same requestId fix (#8069) Co-authored-by: monis.q <monis.q@media.net> * RhythmOne and Unruly Bid Adapter: add gvlid (#8109) * Update rhythmoneBidAdapter.js * Update unrulyBidAdapter.js * Marsmedia adapter: Remove bidderCode from Response (#8108) * Change publisherId to zoneId Add gdpr Add supply chain Add video media type * Remove comments * Fix unit test coverage * fix request id bug add vastXml to video response * Remove bid response default sizes * Change endpoint url * Add unit test for vastXml * Change end point * Remove trailing-space * Add onBidWon function * New adapter - videofy * Marsmedia & Videofy - Add onTimeout onSetTargeting * Create sendbeacon function * - add viewability * remove unnecessary utils.getWindowTop() * Remove bidderCode from response for alias use * Remove unuse that var * NextRoll Bid Adapter: update privacy link and icon (#8105) * Update privacy link and icon for NextRoll BidAdapter * update adapter spec * Criteo - Read mediaTypes.banner.sizes instead of bidRequest.Sizes (#8111) * Smaato: Do not overwrite site.publisher.id (#8112) Co-authored-by: Bernhard Pickenbrock <bernhard.pickenbrock@smaato.com> * Prebid 6.13.0 release * Increment version to 6.14.0-pre * VIS.X: fix bug with onTimeout function arguments (#8110) Co-authored-by: Vladimir Fedoseev <vladimir.fedoseev@yoc.com> * Adriver id system (#8057) * initial commit * adriver id submodule add * add id system tests, fix adriver bid adapter tests * add new lines at the end of files * appnexus bid adapter - add support for pubProvidedId userId (#8015) * Prebid core: bidder-specific control over storage access via `bidderSettings.storageAllowed` (#7992) * Prebid core: bidder-specific control over storage access via `bidderSettings.allowStorage` https://github.com/prebid/Prebid.js/issues/7280 * Refactor signature of getStorageManager * Refactor calls to getStorageManager from bid adapters * Use bidderCode for StorageManager enforcement of bidderSettings.storageAllowed * Update adriver adapter to use new getStorageManager signature * appnexus bid adapter - convert keywords different for psp endpoint (#8115) * Rise Bid Adapter: Added support for banner & gpid (#8083) * add Rise adapter * fixes * change param isOrg to org * Rise adapter * change email for rise * fix circle failed * bump * bump * bump * remove space * Upgrade Rise adapter to 5.0 * starting to combine adUnits to a single request. Added banner media type * improved logic * handle multiple response bids. Updated sent params from buildRequests * removed the old build request function * fixed testMode logic * setting different params by the mediaType, if they're available * updated media format for adUnits (vastXml / html) * updated response structure and some request params * updated request and response structure and logic * fixed netRevenue param * syntax and naming fix * adapter syntax fix and tests partial update according to adapter's new logic * more tests updated. Small adapter tweaks * updated tests to match new request and response structures * fixed config on one of the tests * improved logic * separated query for video and banner keys * added nurl tests * added display tests * updated requests structure and tests video/display together * removed TODO * changes bids object params to camelCase * moved tmax to general params instead of bids. Updated params names in spec file * sending playbackMethod as a single int * sending playbackMethod as a single int * support gpid * changed the playbackMethodValue signal to let * changed vars signal order * moved placement_id key to bids object * changed placementId to camelCase * fixed issue where placementId tried to access wrong object * fixed floorPrice bug * moved currency and netRevenue keys to each bid object * cr * updated placementId value. Added condition to currency and netRevenue * Delete package-lock.json * added package-lock.json back * removed line from package.json * updated some self tests logic * empty commit Co-authored-by: Noam Tzuberi <noam.tzuberi@ironsrc.com> Co-authored-by: noamtzu <noamtzu@gmail.com> Co-authored-by: Noam Tzuberi <noamtzu@users.noreply.github.com> Co-authored-by: Laslo Chechur <laslo.chechur@ironsrc.com> * Colossus Bidder: update user sync (#8050) * add video&native traffic colossus ssp * Native obj validation * Native obj validation #2 * Added size field in requests * fixed test * fix merge conflicts * move to 3.0 * move to 3.0 * fix IE11 new URL issue * fix IE11 new URL issue * fix IE11 new URL issue * https for 3.0 * add https test * add ccp and schain features * fix test * sync with upstream, fix conflicts * Update colossussspBidAdapter.js remove commented code * Update colossussspBidAdapter.js lint fix * identity extensions * identity extensions * fix * fix * fix * fix * fix * add tests for user ids * fix * fix * fix * fix * fix * fix * fix * add gdpr support * add gdpr support * id5id support * Update colossussspBidAdapter.js add bidfloor parameter * Update colossussspBidAdapter.js check bidfloor * Update colossussspBidAdapter.js * Update colossussspBidAdapter.js * Update colossussspBidAdapter.js * Update colossussspBidAdapter_spec.js * use floor module * Revert "use floor module" This reverts commit f0c5c248627567e669d8eed4f2bb9a26a857e2ad. * use floor module * update to 5v * fix * add uid2 and bidFloor support * fix * add pbadslot support * fix conflicts * add onBidWon * refactor * add test for onBidWon() * fix * add group_id * Trigger circleci * fix * update user sync Co-authored-by: Vladislav Isaiko <vladis@smartyads.com> Co-authored-by: Aiholkin <artem.iholkin@smartyads.com> Co-authored-by: Mykhailo Yaremchuk <m.yaremchuk@smartyads.com> * Get floor from correct places on bid object & replace div ID with size (#8093) Co-authored-by: Rachel Joyce <rachelrj@umich.edy> * Improve Digital adapter: custom creative renderer (#7975) * Feature Prebid First Party Data (#2) * HBT-166: Added PageCategory and Genre to request object from First-Party-Data * HBT-166: Added PageCategory and Genre to request object from First-Party-Data and Rewrite Test Cases * Update improvedigitalBidAdapter.js Version increased * Improve Digital COPPA support * Feature/razr integration (#3) Integrated RAZR rich creative renderer * Use renderer interface for Razr Co-authored-by: Faisal Islam <93644923+faisalvs@users.noreply.github.com> Co-authored-by: Samiul Amin Shanto <93644987+samiul-shanto@users.noreply.github.com> Co-authored-by: Faisal Islam <faisal.islam@vivacomsolutions.com> * TheMediaGrid Bid Adapter: added support genre and cat from config ortb2.site (#8041) * TheMediaGrid: added support genre and cat from config ortb2.site * TheMediaGrid: fix bug with possible undefined cat or pagecat * Kargo Bid Adapter: Add currency support for bid response (#8134) * Kargo Bid Adapter: Use currency from Bid Response * Kargo Bid Adapter: Fix failed test Co-authored-by: Jeremy Sadwith <jeremy@kargo.com> * Minutemedia Bid Adapter: add new bid adapter (#8056) * add Rise adapter * fixes * change param isOrg to org * Rise adapter * change email for rise * fix circle failed * bump * bump * bump * remove space * Upgrade Rise adapter to 5.0 * minutemedia adapter * change adresses and mails * mm endpoints * add gvlid * fix * fix tests Co-authored-by: Noam Tzuberi <noam.tzuberi@ironsrc.com> Co-authored-by: Laslo Chechur <laslo.chechur@ironsrc.com> * PBS adapter: partial support of sizeMapping (and sizeMappingV2) (#8084) * Convert sizeMappingV1 to work on adUnits (and not bid requests) * Convert sizemappingV2 to work on adUnits (and not bidRequests) * Warn about unsupported bidder-level sizeMapping configuration in PBS adapter * Kargo Bid Adapter: Removing Salesforce partner support (#8140) * Kargo Bid Adapter: Use currency from Bid Response * Kargo Bid Adapter: Fix failed test * Removing legacy partner code Co-authored-by: Wei Wong <wwong@kargo.com> * Prebid 6.14.0 release * Increment version to 6.15.0-pre * New alias for Aniview prebid adapter (#8125) * Multiple adapters and modules: replace core-js polyfills with simpler stubs (#8136) * Replace core-js polyfills with simpler stubs * Update allowedModules / validateImports * Move stubs to their own package to keep npm imports working without changes * Move polyfills under src * GMOSSP Bid Adapte:Add user module, meta_url. (#8128) * GMOSSP Bid Adapte:Add user module, meta_url. * sharedid.id -> pubcid * un use import getWindowSelf. * test code fix. * test code url fix. * Update RELEASE_SCHEDULE.md (#8142) * Yahoossp Bid Adapter: enable aliasing (#8118) * YahooSSP bid adapter: Enable aliasing * Update text description in test case * Validate aliasing support by testing the bidder code propery is not being set by the bid adapter Co-authored-by: slimkrazy <sam@slimkrazy.com> * added GVLId to goldbachBidAdapter (#8147) * Gnet Bid Adapter: onBidWon (#8114) * Add files via upload * Add files via upload * Change params on gnetBidder * ADJ - Use parseSizesInput to get sizes ADJ - Check serverResponse object ADJ - Remove getUserSyncs function * ADJ - Change prebid endpoint * ADJ - Change endpoint on test * GnetBidAdapter update for Prebid 5.x * Change endpoint and add parameter * import only used function from utils * NEW - onbidWon function * FIX - buildRequests test * FIX - buildRequests test * FIX - buildRequests test especific ambient error Co-authored-by: Roberto Hsu Wu <hsuroberto@gmail.com> Co-authored-by: Roberto Hsu <roberto.wu@grumft.com> Co-authored-by: Denise Balesteros Silva <denise.balesteros@grumft.com> * Restructure data for global window variable. (#8152) (#8153) * Video and banner deal id (#8135) * Adrino Bid Adapter: add new native bid adapter (#8014) * Adrino: new native adapter * add simple check to onBidWon Co-authored-by: Tomasz Mielcarz <tomasz.mielcarz@adrino.pl> * Revert "Adrino Bid Adapter: add new native bid adapter (#8014)" (#8155) This reverts commit 72895a3a5bd58966003bca4b98bdd166602c6c56. * Prebid core: add support for asynchronous access to consent data (#8071) This adds `gpdrDataHandler.promise` and `uspDataHandler.promise`, to enable access to USP/GDPR consent data from outside of an auction context (see use case: https://github.com/prebid/Prebid.js/pull/7803) * Adrino bid adapter: do not use core-js polyfills (#8156) * Revert "Revert "Adrino Bid Adapter: add new native bid adapter (#8014)" (#8155)" This reverts commit 3c7b3cdab7c4e6b64bdca1d31171ff07e6895bb2. * Update Adrino bid adapter to not use core-js polyfill * Bump url-parse from 1.5.1 to 1.5.9 (#8131) Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.9. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.9) --- updated-dependencies: - dependency-name: url-parse dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Adloox Analytics/RTD: use refererInfo (#8092) * SmartHub Bid Adapter: initial release (#8064) * add SmartHub Prebid.js adapter * fix unit tests * fix test params * fix * Update smarthubBidAdapter.md add relevant partnerName * trigger circleci * fix response validation * add netRevenue validation to main condition Co-authored-by: maksym.voloshyn <maksym.voloshyn@smartyads.com> * Prebid Server Bid Adapter: add support for all imp parameters (#8159) * pass imp and fix test * fix lint * fix to mergeDeep * add instl test * remove overlapping testing * cwire Bid Adapter: Add new optional parameters (#8143) * add new global config params * move params from global config to bidder params * fix lint * fix wording, remove unused param * Prebid 6.15.0 release * Increment version to 6.16.0-pre * Add issue tracking workflow (#8162) This adds a GH action to automatically create a project item for every new issue, and update it with the issue creation date. * Move issue_tracker.yml to the correct folder * Novatiq ID System: allow configuration of the sync URL & allow callbacks for specific custom integrations (#8089) * Novatiq snowflake userId submodule Novatiq snowflake userId submodule initial release * change request updates added novatiq info /modules/userId/userId.md added novatiq info /modules/userId/eids.md added novatiq eids /modules/userId/eids.js added novatiq module in /modules/.submodules.json removed unnecessary value from getId response * Update novatiqIdSystem_spec.js removed unnecessary srcid value * Update novatiqIdSystem.md Novatiq ID System: updated novatiq snowflake ID description * use the sharedId if available and configured * updated docs * test changes * defensive code not required * Use the prebid storage manager instead of using native functions * doc changes * trailing spaces * Allow configuration of the sync URL and to allow callbacks for specific custom partner integrations * update documentation * attempt to fix firefox test timeout Co-authored-by: novatiq <79258366+novatiq@users.noreply.github.com> * Rubicon Bid Adapter: Pass along prebid bidId to exchange (#8169) * rubicon pass bidId in * remove console log * targetVideo Bid Adapter: Add GVLID (#8170) * TargetVideo bid adapter * TargetVideo bid adapter * TargetVideo bid adapter * TargetVideo Bid Adapter update * TargetVideo Bid Adapter implementing requested changes * targetVideo Bid Adapter: Add GVLID * Yahoo SSP Bid Adapter: remove unnecessary warning (#8174) * Insticator Bid Adapter: add support schain and eids (#8123) * InsticatorBidAdapter: add support schain and eids * rerun circle ci build * Revert "rerun circle ci build" This reverts commit 936d712012790f437d4ca0c8ad2255c5cd828d78. * Revert "Revert "rerun circle ci build"" This reverts commit f7c5a66a3276ffee7d4a1f6413a444bb4da69865. * Livewrapped adapter: Collect meta data and deal ids (#8176) * Collect metadata * Collect Deal Id * Prebid Core & Browsi RTD provider: Support Vendor Billing with Billable events (#8119) * real time data module, browsi sub module for real time data, new hook bidsBackCallback, fix for config unsubscribe * change timeout&primary ad server only to auctionDelay update docs * support multiple providers * change promise to callbacks configure submodule on submodules.json * bug fixes * use Prebid ajax * tests fix * browsi real time data provider improvements * real time data module, browsi sub module for real time data, new hook bidsBackCallback, fix for config unsubscribe * change timeout&primary ad server only to auctionDelay update docs * support multiple providers * change promise to callbacks configure submodule on submodules.json * bug fixes * use Prebid ajax * tests fix * browsi real time data provider improvements * initial check in * first stuff * Rubicon Passes along Billing Events * fix rubi test * update schema * fix rubi test * listen to billing events * merge browsi events * billable events * remove line * camelcase * lint fixes * unit test * unit test * missing imports Co-authored-by: robertrmartinez <rrmartinez1552@gmail.com> * Prebid Core and Several Bid Adapters: fix win notification price bug (#8171) * Update ttdBidAdapter.js * Update prebid.js * Update secureCreatives.js * Update apacdexBidAdapter.js * Update brightMountainMediaBidAdapter.js * Update axonixBidAdapter.js * Update koblerBidAdapter.js * Update mediaforceBidAdapter.js * Update ttdBidAdapter.js * Update apacdexBidAdapter.js * Update brightMountainMediaBidAdapter.js * Update ttdBidAdapter.js * Changed first party data (#8180) * AdYouLike bidder adapter: update video endpoint (#8166) * add required clickurl in every native adrequest * allows the native response to be given as is to prebid if possible * add unit tests on new Native case * Handle meta object in bid response with default addomains array * fix icon retrieval in Native case * Update priorities in case of multiple mediatypes given * improve robustness and fix associated unit test on picture urls * add support for params.size parameter * add unit test on new size format * Makes sure the playerSize format is consistent * enable Vast response on bidder adapter * fix lint errors * add test on Vast format case * add userId to bidrequest * revert package-lock.json changes * improve multiple mediatype handling * Expose adyoulike GVL id * fix icurl issue when retreiving icon for Native mediatype * update unit tests on icon url in native mediatype * target video endpoint when video mediatype is present * add unit test on video endpoint * detect if bid request has video * remove console log * Adagio: getPrintNumber fix (#8184) use `bidderRequestsCount` instead of `bidRequestsCount` * Rubicon Analytics Adapter: pass along billing events (#8182) * rubicon listens to billing events * billingId is required * remove log * Adprime Bid Adapter: update user sync (#8158) * initial * fix * remove redundant language mod, use player sizes in video traff * test modify * fix * Adding Tests * add keywords param * log * log * log * fix * add idl * add idl * fix test * lint * lint * fix * lint * lint * lint * lint * add sync * fix * add video params, advertiserDomains and getFloor * add audiences param * fix test * update user sync Co-authored-by: Aigolkin1991 <Aigolkin1991@gmail.com> Co-authored-by: Aiholkin <artem.iholkin@smartyads.com> * MediaFuse bid adapter: initial release (#8113) * created MediaFuse Prebid.js bidder adapter I have created alias from appnexus Prebid.js adapter and created one for Mediafuse * updated alias code * updated spec and BidAdapter.js file - Removed mediafuse alias from appenxusBidAdapter.js - mediafuseBidAdapter_spec.js is created from appnexusBidAdpater_spec.js - Removed mediafuseAnalyticsAdapter.js * update the code as per the PR comment * formatted the comment line code * Magnite GVLID used (#8186) * Prebid core: fix log message when enabling a missing analytics provider (#8181) * TheMediaGrid & TrustX bid adapters: reformat first party data (#8146) * Added TheMediaGridNM Bid Adapter * Updated required params for TheMediaGridNM Bid Adapter * Update TheMediGridNM Bid Adapter * Fix tests for TheMediaGridNM Bid Adapter * Fixes after review for TheMediaGridNM Bid Adapter * Add support of multi-format in TheMediaGrid Bid Adapter * Update sync url for grid and gridNM Bid Adapters * TheMediaGrid Bid Adapter: added keywords adUnit parameter * Update TheMediaGrid Bid Adapter to support keywords from config * Implement new request format for TheMediaGrid Bid Adapter * Fix jwpseg params for TheMediaGrid Bid Adapter * Update unit tests for The Media Grid Bid Adapter * Fix typo in TheMediaGrid Bid Adapter * Added test for jwTargeting in TheMediaGrid Bid Adapter * The new request format was made by default in TheMediaGrid Bid Adapter * Update userId format in ad request for TheMediaGrid Bid Adapter * Added bidFloor parameter for TheMediaGrid Bid Adapter * Fix for review TheMediaGrid Bid Adapter * Support floorModule in TheMediaGrid Bid Adapter * Fix empty bidfloor for TheMediaGrid Bid Adapter * Some change to restart autotests * Fix userIds format for TheMediaGrid Bid Adapter * Remove digitrust userId from TheMediaGrid Bid Adapter * Protocols was added in video section in ad request for TheMediaGrid Bid Adapter * TheMediaGrid: fix trouble with alias using * TheMediaGridNM: fix trouble with alias * TheMediaGrid Bid Adapter: added support of PBAdSlot module * TheMediaGrid Bid Adapter: fix typo * GridNM Bid Adapter: use absent in params data from mediaTypes * GridNM Bid Adapter: fix md file + add advertiserDomains support * TheMediaGrid and gridNM Bid Adapter: minor netRevenue fixes * gridNM Bid Adapter updates after review * TheMediaGrid Bid Adapter: fix keywords workflow * fix testing and kick off lgtm again * TheMediaGrid: added ext.bidder.grid.demandSource processing * TheMediaGrid: added user.id from fpd cookie * TheMediaGrid: control cookie setting via bidder config * TheMediaGrid: use localStorage instead cookie * TheMediaGridNM Bid Adapter: update adapter to use /hbjson endpoint * TheMediaGridNM: fix unnecessary conditions * TheMediaGrid: fix bug with nurl field in response * TheMediaGrid: update test * TheMediaGridNM: fix possible bug with nurl * TheMediaGrid: added alias as playwire * TheMediaGrid: added alias as adlivetech * TheMediaGrid: fix sync url workflow * TrustX: fix sync url worflow + remove old syncurl * TheMediaGrid: added instl support * TheMediaGrid: fix test for instl * TheMediaGrid: update md file * TheMediaGrid: reformat segments for permutive rtd module * TrustX: send all ortb2.user.data in user.data * TheMediaGrid: remove permutive segments reformating * TrustX: remove permutive segments reformating * TheMediaGrid & TrustX: fix typo Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> * Rubicon Analytics: handle bad auction case (#8192) * handle bad auction * rename auctionCache * Ad Generation Bid Adapter: add NovatiqSystem (#8178) * update Adgeneration to add NovatiqSystem. * Add IOS check * update adapter version * fix novatiq object * Prebid 6.16.0 release * Increment version to 6.17.0-pre * Dacid User Id Module: add new id module (#8187) * Add dacid user id module * Fix source domain * Add document to explain dac ID * Insticator adapter: add support gpid (#8189) * Insticator adapter: add support gpid * Update insticatorBidAdapter_spec.js Rerun build * Switch to use imp.ext.gpid field * Build system: upgrade webpack (#7935) * Upgrade webpack to 5; gulp build works * Fix karma, except events * Uniform access to events, import * or require (import * from 'events.js' / import events from 'events.js' return different objects, which is a problem for stubbing) * Fix (?) adapters that use `this` inappropriately * Update webpack-bundle-analyzer * Fix warnings * Enable tree shaking * Set webpack mode 'none' (or else tests fail (!)) * Update coreJS version in babelrc - https://github.com/prebid/Prebid.js/issues/7943 * Use babel to translate to commonjs only for unit tests; enable production mode * Merge master * Add fsevents as optional dep * Fix imports of `events` in browsiRtdProvider to work with https://github.com/prebid/Prebid.js/pull/7935 (#8197) * Update prebid.js (#8190) * Open8 Bid Adapter: Add `advertiserDomains` support to comply with Prebid.js 5.0 (#8127) * add open8 adapter * slotkey and fix * add maintainer address * add bidwon * check field populated * Now Open8 adapter produced result object contains Prebid.js v5 mandatory field "meta.advertiserDomains". * Import only used symbols from "utils.js". Co-authored-by: 木田 愛一郎 <kidaa@O8MBP3-125.local> Co-authored-by: Takahashi Kenta <rika-t@castify-inc.com> * userId Module: Added getEncryptedSignalfromSources and registerSignalsources fun… (#8117) * ESP: Added getEncrptedSignalfromSources and registerSignalsources function to send eids to GAM * Lint issue resolved * ESP: Changes in code based on review comments * ESP: Changes in code based on review comments * ESP: Example HTML added * ESP: Removed duplicate key from example.html * ESP: GetUserEids by source name function added and change requested done * ESP: SignalSources name changed to encryptedSignalSources under usersync object * ESP: Added encryptedSignalConfig in userSync object having signal sources with customSources * ESP: ESP example HTML modified * ESP: removed unwanted arguments/parameters * Test cases: Module added to test getUserIdsByEidsBySource function * ESP: Added concat function instead of Object.assign * Removed enableSingleRequest() calling from the code - testpage * ESP: Lint issue solved * ESP: LGTM alert issue fixed(This is always true) * ESP: updated userid spec file and removed unwanted code * ESP: Added check if registerDelay timeout is undefined and gtag check * ESP: ESP configs updated and code clean up based on review comments * ESP: Converted normal function to arrow functions * ESP: Test cases position changed * ESP: Handle undefined and null check * add support for the schain option to the conversant adapter (#8203) * Update kargoBidAdapter.js (#8205) * Flashtalking FTRACK User ID Submodule: initial release (#8063) * JDB-496: first commit, copying over files from prebid-js-ftrack-module PR-1.0.0 ftrack user ID submodule code * Addressing the lgtm alert * Addressing the remaining lgtm alerts * Setting VENDOR_ID to null for now * Pulled ftrack out and used a config.param property instead to load ftrack * Cleaning up errors raised by linter * Tweaking a comment * JDB-496: cleaning up docs based on PR feedback * PR fixes Co-authored-by: Jason Lydon <jason.lydon@flashtalking.com> * Id ward RTD Module: initial release (#8076) * added idWardRtdProvider module * added idward_segments_example.html to test module * improver description * added 'Testing' section to readme * added missing function description * show sent FPD at the example html page * review comments resolved Co-authored-by: Pavlo <pavlo@id-ward.com> * Synacormedia Bid Adapter: ttl and eid update (#8006) * CAP-2474 Synacor Media Bid Adapter: Use OpenRTB parameters to populate bids' `ttl` values * CAP-2474 Revised bid expiration/ttl code to conform to revised requirements w/ adserver tag expiration * CAP-2474 Added tests and cleaned up tag expiration code * feature/CAP-2516: Remove the filtering of eids for synacormediaBidAdapter Co-authored-by: Andrew Fuchs <andrew.fuchs@synacor.com> Co-authored-by: Timothy M. Ace <tace@imds.tv> Co-authored-by: Tim Ace <tace@synacor.com> * FTrackIdSystem & IDWardRtdProvider: fix calls to `getStorageManager` (#8208) * Mediasquare Bid Adapter: add metrics to onBidWon Event (#8209) * remove old userSyncs method * Update mediasquareBidAdapter.js * Update mediasquareBidAdapter.js * Update mediasquareBidAdapter_spec.js * Mediasquare Bid Adapter: add floor module support * Update mediasquareBidAdapter_spec.js * Update mediasquareBidAdapter.js * Rubicon Analytics, pass along gpid (#8210) * PubMatic Bid Adapter: Added multibid support for GroupM (#8193) * Changed net revenue to True * Added miltibid support for GroupM * Added marketplace array to check for values * Added marketplace check while requesting too Co-authored-by: Azhar <azhar@L1119.local> * Add banner support to readpeak bid adapter (#8179) * Prebid core & PBS adapter: better support for server-side stored impressions (#8154) * Update ad unit validation to allow no bids if ortb2Imp is specified * Move s2sTesting logic to the s2sTesting module * Accept adUnit.storedAuctionResponse in lieu of adUnit.bids; update PBS adapter to work with no-bid adUnits * Do not accept 'storedAuctionResponse' as an alternative to 'ortb2Imp' * Fix short-circuit in building out imp[].ext * Make `s2sConfig.bidders` optional * UserID module: fix esp unit test (#8212) * ESP:Assetion Issue solved * Prebid 6.17.0 release * Increment version to 6.18.0-pre * AdHash Bid Adapter: add brand safety (#8167) * AdHash Bidder Adapter: minor changes We're operating on a com TLD now. Added publisher in URL for easier routing. * Implemented brand safety Implemented brand safety checks * Fix for GDPR consent Removing the extra information as request data becomes too big and is sometimes truncated * Ad fraud prevention formula changed Ad fraud prevention formula changed to support negative values as well as linear distribution of article length * jpBidAdapter - pass additional param in request (#8188) Tests updated Bump version to 1.8.2 * only map one slotrender to one adunit (#8211) * DFP Ad Server Video: respect original url (#8168) * original url components take precedence over defaults uses object assignment * tests that url is respected * respects url size and cust params * moves url cust param addition to fn * tests that url params are respected * Admaru adapter : add new bid adapter (#8149) * init * modified admaruBidAdapter.js, md, _spec.js * modify for test * Delete .project * update * update admarubidadapter.js * Revert "Delete .project" This reverts commit 0e1bdd4fcadd0a97fea87ba2a92cb502e5e3a19b. * remove .project * modified * modified * Delete .project * modified * Revert "Delete .project" This reverts commit c4e7bd6096fe9521dd5e2fab2b3d5241149dc6ec. * Delete .project * modified * modified Co-authored-by: sung.chung <sung.chung@admaru.com> * Missena Bid Adapter - allow custom endpoint. (#8222) * Next Millenium Bid Adapter: Added new parameter group_id (#8200) * changed name company * changed name company in test * Added processing of a new group_id parameter * Added processing of a new group_id parameter * changed check parameters * fixed lint remarks * added test * fixed bug - lint * changed test * changed test - 2 * fixed bug - adapter * add timeout value to timeout pixel (#8224) * Outbrain bid adapter: added floor module and privacy link support (#8223) * add floor support * add additional validation for bid request format * add privacy link support * fixes * set privacy in mapper * fix test * Improve Digital Bid adapter: use the oRTB server endpoint (#8138) * Major refactoring to use new oRTB server endpoint Co-authored-by: Faisal Islam <100519197+iosfaisal@users.noreply.github.com> Co-authored-by: Jozef Bartek <31618107+jbartek25@users.noreply.github.com> * fixed wrong merge * Fixed issue related to site and app (#9) * Fixed errors for test cases. Co-authored-by: Faisal Islam <93644923+faisalvs@users.noreply.github.com> Co-authored-by: Faisal Islam <100519197+iosfaisal@users.noreply.github.com> Co-authored-by: Faisal Islam <faisal.islam@vivacomsolutions.com> * NativoBidAdapter - Bid data mapping refactor and added QS params on request (#8196) * Initial nativoBidAdapter document creation (js, md and spec) * Fulling working prebid using nativoBidAdapter. Support for GDPR and CCPA in user syncs. * Added defult size settings based on the largest ad unit. Added response body validation. Added consent to request url qs params. * Changed bidder endpoint url * Changed double quotes to single quotes. * Reverted package-json.lock to remove modifications from PR * Added optional bidder param 'url' so the ad server can force- match an existing placement * Lint fix. Added space after if. * Added new QS param to send various adUnit data to adapter endpopint * Updated unit test for new QS param * Added qs param to keep track of ad unit refreshes * Updated bidMap key default value * Updated refresh increment logic * Refactored spread operator for IE11 support * Updated isBidRequestValid check * Refactored Object.enties to use Object.keys to fix CircleCI testing errors * Updated bid mapping key creation to prioritize ad unit code over placementId * Added filtering by ad, advertiser and campaign. * Merged master * Added more robust bidDataMap with multiple key access * Deduped filer values * Rolled back package.json * Duped upstream/master's package.lock file ... not sure how it got changed in the first place * Small refactor of filterData length check. Removed comparison with 0 since a length value of 0 is already falsy. Co-authored-by: Joshua Fledderjohn <jfledderjohn@nativo.com> * Floor price : allow having a 0$ floor (#8239) * Prebid 6.18.0 release * Increment version to 6.19.0-pre * IAS RTD Module: Custom key values (#8214) * Mapping table initialization A constant initialises a mapping table where each possible key used by IAS is mapped to itself. The dataProviders config for the IAS RTD module accepts an optional new property: keyMappings. The init function reads this property and uses it to overwrite any key that is already in the pre-initialised mapping table with the new value provided. In a future addition, the mapping table will be used to populate the key-values actually sent to the adserver. * Rename Key Values After merging the key-values for each ad unit, a renaming function is called to ensure that any custom key chosen by the client is used. * Bugfix Call the callback() function in getBidRequestData. * Unit tests changed to include one renamed parameter. * Unit tests corrected and adapted to cover the current features. * Yieldlab Bid Adapter: Add Support for User Matching (#8148) * Build system: add option to generate source maps for production builds (#8220) * Gamoshi Bid Adapter: Handle gdpr applies correctly (#8245) * Nobid Prebid Adapter commit (#4050) * Nobid Prebid Adapter commit * Fixed global replace and unit tests * Fixed find function * Added nobidBidAdapter.md * Removed description and added "Bid Params" section. * Added test siteId 2 for testing. * Refactored the Adapter to remove most references to the nobid object. We still need the nobid object because we have a passback tag in DFP that makes reference to it. * Fix concurrent responses on the page * Cosmetic change to log an error in case of missing ad markup * Keep nobid.bidResponses cross adapters. * Added GDPR support in user sync and added test coverage. gulp test-coverage gulp view-coverage * Padding issues * Fix padding issues * Fix padding * update outstream prod url (#4104) * support pubcid and uids (#4143) * Fix misspelling and minor cleanup of schain docs (#4150) * Prebid 2.31.0 Release * Increment pre version * Rubicon: tuning logged messages (#4157) * Rubicon: tuning logged messages * Update rubiconBidAdapter.js * fixed indentation * Rubicon Video COPPA fix (#4155) * Rubicon Video COPPA fix * Unit test for Rubicon Video COPPA fix * Playground XYZ adapter - iframe usersync bug fix (#4141) * corrected user sync type * removed support for iframe usersync * added unit tests for getUserSyncs * update nvmrc file (#4162) * update gulp-footer package (#4160) * Datablocks bid/analytics adapter (#4128) * add datablocks Analytics and Bidder Adapters * remove preload param * remove preloadid * better coverage of tests * better coverage * IE doesn't support array.find * lint test * update example host * native asset id should be integer * update logic of ad_types field in appnexusBidAdapter (#4065) * Shorten SomoAudience to just Somo (#4163) * Shorten SomoAudience to just Somo * Make package-lock return * Quantcast: Fix for empty video parameters (#4145) * Copy params from bid.params.video. * Added test for missing video parameters. * Include mimes from adunit. * One Video adding Rewarded Video Feature (#4142) * outstream changes * removing global filtet * reverting page * message * adapter change * remove space * testcases * testpage * spaces for test page * renderer exist case * reverting package-lock.json * adding schain object * adding tagid * syntaxx error fix * video.html * space trailing * space * tagid * inventoryId and placement * rewarded video * added unit test case * Module to pass User Ids to DFP (#4140) * first commit * renamed * minor doc change * documentation * small change * EB * removed unused imports * minor changes * reanmaed a const * adding more methods to test shareUserIds module * unit tets cases for shareUserIds * indentation * renamed DFP to GAM * renamed shareUserIds to userIdTargeting * Update userIdTargeting.md * trying to restart CI * digitrust userId case handled * minor comment change * using auctionEnd event instead of requestBids.before * using events.on * Buzzoola bid adapter (#4127) * initial commit for buzzoola adapter * leave only banners for now * fix bid validation * change endpoint url * add video type * restore renderer * fix renderer * add fixed player sizes * switch bids * convert dimentions to strings * write tests * 100% tests * remove new DOM element creation in tests * handle empty response from server * change description * E2e tests for Native and Outstream video Ad formats. (#4116) * reorganize e2e/ tests into separate directories * new test page for e2e-banner testing * add test to check if Banner Ad is getting loaded * change location of the spec files to reflect change in test/e2e directory structure * add test case to check for generation of valid targeting keys * create Native Ad test page * add test case to check validity of the targeting keys and correct rendering of the Ad * update old browser versions to new * update browser version * update title * remove console.log statements * add basic functional test for e2e outstream video ad format * Update LockerDome adUnitId bid param (#4176) This is not a breaking change * fix several issues in appnexus video bids (#4154) * S2s testing disable client side (#4123) * Add microadBidAdapter * Remove unnecessary encodeURIComponent from microadBidAdapter * Submit Advangelists Prebid Adapter * Submit Advangelists Prebid Adapter 1.1 * Correct procudtion endpoint for prebid * analytics update with wrapper name * reverted error merge * New testServerOnly flag * Tests and a bug fix * Removed dead code * Fixes requested in review * Check each adUnit * isTestingServerOnly changes per Eric * Fixed IE 11 bug * More tests * improved test case names * New option to Include deal KVPs when enableSendAllBids === false (#4136) * new option to include KVPs which have deals when enableSendAllBids === false * updating tests to be more realistic * Prebid 2.32.0 Release * increment pre version * Rubicon doc: changing video test zone (#4187) * added schain support to sonobi adapter (#4173) * if schain config is not defined then error should not be thrown (#4165) * if schain config is not defiend then error should not be thrown * relaxed mode nodes param not defined error handled * added test cases for config validation * a curly bracket was missing in the example * Rubicon: updating test params (#4190) * myTargetBidAdapter: support currency config (#4188) * Update README.md (#4193) * Update README.md * Update README.md * cedato bid adapter instream video support (#4153) * Added adxpremium prebid analytics adapter (#4181) * feat(OAFLO-186): added support for schain (#4194) * Sonobi - send entire userid payload (#4196) * added userid param to pass the entire userId payload to sonobis bid request endpoint * removed console log git p * fixed lint * OpenX Adapter fix: updating outdated video examples (#4198) * userId - Add support for refreshing the cached user id (#4082) * [userId] Added support for refreshing the cached user id: refreshInSeconds storage parameter, related tests and implementation in id5 module * [userId] Added support for refreshing the cached user id: refreshInSeconds storage parameter, related tests and implementation in id5 module * UserId - ID5 - Updated doc with new contact point for partners * UserId - Merged getStoredValue and getStoredDate * [UserId] - ID5 - Moved back ID5 in ./modules * UserId - ID5 - Fixed incorrect GDPR condition * [UserId] - Doc update and test cleanup * Prebid 2.33.0 Release * Increment pre version * SupplyChainObject support and fires a pixel onTimeout (#4152) * - Implemented the 'onTimeout' callback to fire a pixel when there's a timeout. - Added the ability to serialize an schain object according to the description provided here: https://github.com/InteractiveAdvertisingBureau/openrtb/blob/master/supplychainobject.md * some mods to the schain tag generation * - added tests for schain param checking. * - fixed a malformed url for timeouts * - Removed a trailing ',' while generating a schain param. * - Using the schain object from validBidRequest if present. Reverting to checking if params has it if not. * - reverting changes to merge with master * - Resolving merge issues * Feature/add profile parameter (#4185) * Add optional profile parameter * EMXDigital Bid Adapter: Add video dimensions in request (#4174) * addressed feedback from #3731 ticket * removed commented code from emx test spec * logging removed from spec * flip h & w values from playerSize for video requests * adding Outstream mediaType to EMX Digital * adding device info. update to grab video param. styling changes. * add video dimensions from playerSize * fix test for video dimensions * Added keywords parameter support in TrustX Bid Adapter (#4183) * Add trustx adapter and tests for it * update integration example * Update trustx adapter * Post-review fixes of Trustx adapter * Code improvement for trustx adapter: changed default price type from gross to net * Update TrustX adapter to support the 1.0 version * Make requested changes for TrustX adapter * Updated markdown file for TrustX adapter * Fix TrustX adapter and spec file * Update TrustX adapter: r parameter was added to ad request as cache buster * Add support of gdpr to Trustx Bid Adapter * Add wtimeout to ad request params for TrustX Bid Adapter * TrustX Bid Adapter: remove last ampersand in the ad request * Update TrustX Bid Adapter to support identical uids in parameters * Update TrustX Bid Adapter to ignore bids that sizes do not match the size of the request * Update TrustX Bid Adapter to support instream and outstream video * Added wrapperType and wrapperVersion parameters in ad request for TrustX Bid Adapter * Update TrustX Bid Adapter to use refererInfo instead depricated function utils.getTopWindowUrl * HOTFIX for referrer encodind in TrustX Bid Adapter * Fix test for TrustX Bid Adapter * TrustX Bid Adapter: added keywords passing support * rubicon: avoid passing unknown position (#4207) * rubicon: not passing pos if not specified * added comment * not sending pos for video when undefined * cleaning up test * fixed unit test * correctly reference bidrequest and determine mediatype of bidresponse (#4204) * GumGum: only send gdprConsent when found (#4205) * adds digitrust module, mods gdpr from bool to int * update unit test * only send gdprconsent if present * LKQD: Use refererInfo.referer as fallback pageurl (#4210) * Refactored URL query parameter passthrough for additional values, changed SSP endpoint to v.lkqd.net, and updated associated unit tests * Use refererInfo.referer as fallback pageurl * Removed logs and testing values * [UserId] - ID5 - Fixed case when consentData is undefined (No CMP) (#4215) * create stubs for localStorage in widespaceBidAdapter test file (#4208) * added adId property to adRenderFailed event (#4097) When no bid (therefore no adUnitCode) is available in the adRenderFailed event it can be difficult to identify the erroring slot.But in almost all cases the given slot still has the adId targeting. * OpenX Adapter: Forcing https requests and adding UserID module support for LiveRamp and TTD (#4182) * OpenX Adapter: Updated requests to force https * OpenX Adapter: Added support for TTD's UnifiedID and LiveRamp's IDL * PubMatic to support userId sub-modules (#4191) * added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * TripleLift support for UnifiedId and IdentityLink (#4197) * Add IdentityLink support and fix UnifiedId. It appears we've been looking for UnifiedId userIds on the bidderRequest object, when they are found on bidRequests. This commit fixes that error, and adds support for IdentityLink. * change maintainer email to group * Added lemma adapter (#4126) * lemmaBidAdapter.js Added lemma bid adapter file * lemmaBidAdapter.md Added lemma bid adapter md file * lemmaBidAdapter_spec.js Added lemma bid adapter test spec file * Update lemmaBidAdapter.js Fixed automated code review alert comparison between inconvertible types * Update lemmaBidAdapter.js Fixed review changes * Update lemmaBidAdapter.md Correct parameter value. * Adkernel adapter new alias (#4221) * Force https scheme for Criteo Bidder (#4227) * assign adapter version number * Ensure that Criteo's bidder is always called through https * Add Video Support for Datablocks Bid Adapter (#4195) * add datablocks Analytics and Bidder Adapters * remove preload param * remove preloadid * better coverage of tests * better coverage * IE doesn't support array.find * lint test * update example host * native asset id should be integer * add datablocks Video * remove isInteger * skip if empty * update adUnit, bidRequest and bidResponse object (#4180) * update adUnit, bidRequest and bidResponse object * add test for mediaTypes object * 3 display banner and video vast support for rads (#4209) * add stv adapter * remove comments from adapter file * start rads adapter * fix adapter and tests * fixes * fix adapter and doc * fix adapter * fix tests * little fix * add ip param * fix dev url * #3 radsBidAdapter.md * #3 radsBidAdapter.md: cleanup * fix code and doc * UserId - Add SameSite and server-side pubcid support (#3869) * Add SameSite and server-side pubcid support * Fix emoteevBidAdapter unit test * added schain to appnexus bid adapter (#4229) * added schain to appnexus bid adapter * semicolon * update doubleclick url (#4179) * Prebid 2.34.0 release * increment pre version * Rubi Analytics handles > 1 bidResponse per bidRequest (#4224) * videoNow bid adapter (#4088) * -- first commit * -- cors and bidder's name fixed * -- almost ready * -- added docs * -- added nurl tracking * -- bid params * -- tests added * -- test fixed * -- replace placeholder in the onBidWon pixel's url * -- commit for restart tests * -- change response data format for display ad * -- tests updated * -- 100% tests coverage * -- a few clean the test's code * -- custom urls from localStorage * -- tests updated * -- a few clean the test's code * -- new init model * -- spec for new init model * -- fix for new init model * -- code cleaned * -- 100% tests coverage * -- 100% tests coverage * -- fixed test * -- commit for restart tests * djax new bidder adapter (#4192) * djax bidder adapter * djax bidder adapter * Update hello_world.html * Added Turk Telekom Bid Adapter (#4203) * Added Turk Telekom Bid Adapter * Fix md file for Turk Telekom Bid Adapter * MicroAd: Use HTTPS in all requests (#4220) * Always use HTTPS endpoint in MicroAd * Update code * Fixed a broken test in MicroAd * Schain: avoiding Object.values as it is breaking on IE11 (#4238) * added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * avoiding use of Object.values * 3952 delay auction for ids (#4115) * 3952 delay auction for user ids * 3952 add integration example * 3952 add tests * 3952 fix html example * add todos * 3952 continue auction if ids received * 3952 add tests for auction delay * increase test coverage * set config for test * remove todo * add a few more checks to tests * add comment, force tests to rerun * Feature: adUnitBidLimit (#3906) * added new feature to config to limit bids when sendallbids is enabled * cleaned up code. removed extra spaces etc * removed trailing spaces in config * remove .flat() and replaced with spread operator * removed flat function and instead pushing using spread operator * updated to use sendBidsControl instead * updated targeting_spec to test bidLimit * removed trailing spaces from targeting_spec * Update Rubicon Adapter netRevenue default (#4242) * Add microadBidAdapter * Remove unnecessary encodeURIComponent from microadBidAdapter * Submit Advangelists Prebid Adapter * Submit Advangelists Prebid Adapter 1.1 * Correct procudtion endpoint for prebid * analytics update with wrapper name * reverted error merge * update changed default value of netRevenue to true * Removed AdastaMadia from alias (#4255) * Update appnexusBidAdapter.js (#4251) * IdentityLink - change expiration time to 30 days (#4239) * Add coppa support for AppNexus adapter (#4253) * Add coppa support for AppNexus adapter * test name * add new longform e2e tests (#4206) * Konduit module (#4184) * Adding Konduit module * Removed superfluous arguments passed to obtainVastUrl function * Removed superfluous arguments passed to obtainVastUrl function. * Build trigger (empty commit) * Module documentation updated according to the comments * Logic in obtainVastUrl function updated according to the review comment. * Removed hook, enabled eslint * Circle CI runs e2e tests on every push (#4200) * run functional tests on circle ci on push to any remote branch * remove extraneous key from config file * add test.localhost as alias to 127.0.0.1 * check 0: execute circle-ci * move /etc/config to a separate command * change bid partner to rubicon * test appnexus bid adapter in ci * comment browserstack command * remove console.log statement * test1: circle-ci * change reference dev -> prod while loading prebid * add console.log statement * check-2: circle-ci * comment browserstack testing * change bid adapter * change bid adapter * remove test case for checking targeting keys * remove the ci flag * uncomment test for checking correct generation of targeting keys * swap AN -> Rubicon for testing targeting keys * Outcon bid adapter. (#4161) * Outcon bid adapter. * Fix identation * Fixes * Fixes * Fixes * Spec fixes * Fixes * Fix urls * Fix * Fix parameters * Fix space operators * Fix bidder timeout * Update * Fix whitespace * no message * Outcon unit test * no message * no message * no message * no message * Fixes * Fixes * Change url * no message * no message * no message * Added bidId * no message * no message * no message * no message * Wrapping url with html * no message * no message * no message * Adding workflow to run end to end tests (#4230) * Adding workflow to run end to end tests * trying self branch * Update to run at 12 every day * cleanup config using aliases * update branch and cron time * add command * update prebid path for e2e test pages (#4274) * Prebid 2.35.0 release * Increment pre version * Add usersync to adpone adapter (#4245) * add user sync to adpone adapter * move adpone usersync to global variable * added withcredentials to http request * fix http request options * fix http request options * add withCredentials: true * add withCredentials: true * added test coverage to usersync * update sync function * add test coverage * adpone adapter * package lock * add more testing * add more testing * testing for onBidWon fucntion * test onbidwon function * trigger build * Revert GumGum Adapter 2.28 resizing changes (#4277) * changed resizing unit tests to return the first size dimensions in the sizes array * added some changes * reverted adapter changes * SpotX Bid Adapter: Support schain, ID5 object, Google consent object, and hide_skin (#4281) * Add SpotXBidAdapter * Minor updates * Undo testing changes to shared files * Fix relative imports * Remove superfluous imports and write a few more tests * Formatting, ID5 object, Google consent objects - Added ID5 object support - Added Google Consent object - Reformatted indentaiton on spec file * Revert content_width and content_height changes in docs - not sure how these got moved, lets put them back * Remove click_to_replay flag in example - no reason to use this one in the example * Spotx adapter - Add schain support and update unit tests * Update schain path in ORTB 2.3 request body - schain object is now added to ortb request body at request.ext.source.ext.schain * Add hide_skin to documentation - whoops, this got removed, let's add it back * Update Rubicon Analytics Adapter `bidId` to match PBS (#4156) * Add microadBidAdapter * Remove unnecessary encodeURIComponent from microadBidAdapter * Submit Advangelists Prebid Adapter * Submit Advangelists Prebid Adapter 1.1 * Correct procudtion endpoint for prebid * analytics update with wrapper name * reverted error merge * update for rubicon analytics to send seat[].bid.id for PBS video and banner * fixed conditional for server and video or banner * updated with optimized value test for bidid * update changed default value of netRevenue to true * remove var declaration for rightSlot to correct lgtm error for unused variable * update defineSlot div id to match div id defined in html body * update test ad unit test props * revert lock to match remote master * add seatBidId to bidObj in rpBidAdapter interpretResponse * update setTargeting to execute in the bids back handler * remove dev integration test page * meaningless commit to get lgtm to re-run * SmartRTB adapter update (#4246) * modules: Implement SmartRTB adapter and spec. * Fix for-loop syntax to support IE; refactor getDomain out of exported set. * Remove debugs, update doc * Update test for video support * Handle missing syncs. Add video to media types in sample ad unit * Add null response check, update primary endpoint * Note smrtb video requires renderer * Support Vast Track (#4276) * Add microadBidAdapter * Remove unnecessary encodeURIComponent from microadBidAdapter * Submit Advangelists Prebid Adapter * Submit Advangelists Prebid Adapter 1.1 * Correct procudtion endpoint for prebid * analytics update with wrapper name * reverted error merge * update changed default value of netRevenue to true * Add parameters if config.cache.vasttrack is true * Use requestId instead of adId * Test new vasttrack payload params * Removed commented out code * Relaxed conditional check per review * Removed commented out line * Added 1000x250 size (#4295) * prepare vidazoo adapter for v3.0 (#4291) * Improve Digital adapter: support schain (#4286) * LiveIntent Identity Module. (#4178) * LiveIntentIdSystem. Initial implementation. * LiveIntentIdSystem. Removed whitespace. * Fixed typo * Renamed variables, cookiesm added md. * Changed the default identity url. * Composite id, with having more than just the lipbid passed around. * Composite id. * Merge conflict resolution. * Changed docs and param description. * Added typedoc & mentioned liveIntentIdSystem in submodule.json. * Extracted the LiveIntentIdSystem under modules, removed it from default userId modules. * Fixing the 204 + no body scenario. * Added liveIntent to submodule.json * Fixing docs indentation. * Updated prebidServer & specs. * Minor specs update. * updating liveintent eids source (#4300) * updating liveintent eids source these are supposed to be domains * updating unit test * fix appnexusBidAdapter view-script regex (#4289) * fix an view script regex * minor syntax update * 33Across adding bidder specific extension field (#4298) * - add 33across specific ext field for statedAt * - fix unit test for 33Across adapter * PubMatic to support LiveIntent User Id sub-module (#4306) * added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * supporting LiveIntent Id in PubMatic adapter * updated source for liveintent * Finteza Analytics Adapter: fix cookies (#4292) * fix reading and sending cookies * fix lint errors * clear comments * add unit tests * fix calling of setCookies for IE * clear cookies after test * use own setCookie method inside tests * Update LockerDome adapter to support Prebid 3.0 (#4301) * Returning the `IdResponse` type with an obj + callback. Fix for 4304 (#4305) * Returning the `IdResponse` type with an obj + callback. * Renamed resp -> result. * Removed whitespace. * ShowHeroes adapter - expanded outstream support (#4222) * add ShowHeroes Adapter * ShowHeroes adapter - expanded outstream support * Revert "ShowHeroes adapter - expanded outstream support" This reverts commit bfcdb913b52012b5afbf95a84956b906518a4b51. * ShowHeroes adapter - expanded outstream support * ShowHeroes adapter - fixes (#4222) * ShowHeroes adapter - banner and outstream fixes (#4222) * ShowHeroes adapter - description and outstream changes (#4222) * ShowHeroes adapter - increase test coverage and small fix * [Orbidder-Adapter] Add bidRequestCount and remove bid.params.keyValues (#4264) * initial orbidder version in personal github repo * use adUnits from orbidder_example.html * replace obsolete functions * forgot to commit the test * check if bidderRequest object is available * try to fix weird safari/ie issue * ebayK: add more params * update orbidderBidAdapter.md * use spec.<function> instead of this.<function> for consistency reasons * add bidfloor parameter to params object * fix gdpr object handling * default to consentRequired: false when not explicitly given * wip - use onSetTargeting callback * add tests for onSetTargeting callback * fix params and respective tests * remove not used bid.params.keyValues * add bidRequestCount to orbidder.otto.de/bid Post request * add bidRequestCount to test object defaultBidRequest * PulsePoint: remove usage of deprecated utils method / prep for 3.0 (#4257) * ET-1691: Pulsepoint Analytics adapter for Prebid. (#1) * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change * Adding bidRequest to bidFactory.createBid method as per https://github.com/prebid/Prebid.js/issues/509 * ET-1765: Adding support for additional params in PulsePoint adapter (#2) * ET-1850: Fixing https://github.com/prebid/Prebid.js/issues/866 * Minor fix * Adding mandatory parameters to Bid * Removing usage of deprecated utils method * minor refactor * Use isArray method (#4288) * Add Parrable ID submodule (#4266) * add parrable id submodule * fix integration test config * fix var name * always refresh sotredId for parrable * add submodulesThatAlwaysRefresh concept * remove comment * add parrable url as one string * add parrable prod endpoint * use .indexOf instead of .includes * add params to test config * comment failing test * uncomment failing assertion * add parrable ID to prebid server adapter * add parrableIdSystem to .submodules.json * extract parrableId unit tests from userId spec * remove breakline between imports * remove unused param * remove userId generic feature from parrableId module * remove trailing space * fix failing test due to none merged conflict * Prebid 2.36.0 Release * Increment pre version * Support schain module and send bidfloor param in Sharethrough adapter (#4271) * Add support for supply chain object module Story: [#168742394](https://www.pivotaltracker.com/story/show/168742394) Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Add bidfloor parameter to bid request sent to STX Story: [#168742573](https://www.pivotaltracker.com/story/show/168742573) * Platform One Analytics Adapter (#4233) * Added Y1 Analytics Adapter * rename y1AnalyticsAdapter in yieldoneAnalyticsAdapter * Yieldone Bid Adapter: fixes from lint check * Yieldone Analytics Adapter: fix endpoint protocol * Added spec file for yieldone Analytics Adapter * Fix parrable id integration example (#4317) * fix parrableId integration example * add parentheses * Improve Digital adapter: support for video (#4318) * Bid floor, https, native ad update * Update the ad server protocol module * Adding referrer * Improve Digital support for video * Improve Digital adapter: video * adapter version -> 6.0.0 * Gamoshi: Update aliases list. Add support for userSync. (#4319) * Add support for multi-format ad units. Add favoredMediaType property to params. * Add tests for gdpr consent. * Add adId to outbids * Modify media type resolving * Refactor multi-format ad units handler. * Modify the way of sending GDPR data. Update aliases. * Add new consent fields. Add unit test. * Add new consent fields. Add unit test. * Add support for id5 and unified id cookie sync. * Add support for id5 and unified id cookie sync. * Add restricted check for gdpr consent. * fix for userSync endpoint getting called with bidder alias names, instead of actual bidder names (#4265) * modify ixBidAdapater to always use the secure endpoint (#4323) * PubMatic to support Parrable User Id sub-module (#4324) * added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * PubMatic to support parrable id * VISX: currency validation & fix double escape of referer (#4299) * PubMatic to support coppa (#4336) * added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * added coppa compliance * vuble: outstream has fullscreen option (#4320) * Mod: vuble oustream has fullscreen option * Add: vuble test for outstream scenario * EMXDigital: hotfix to resolve URIError from decodeURIComponent (#4333) * hotfix to resolve URIError from decodeURIComponent * added unit for decoding adm * Specify second parameter for parseInt for pubmaticBidAdapter (#4347) * Remove usage of getTopWi…
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Upgrade to webpack 5.
Also enables tree shaking (as per #7867), but it does not appear to be that effective - there is no significant difference in the final bundle size. As I understand it, tree shaking is supposed to erase unused modules - so this is not surprising given that modules are included only if they are imported.
Notes:
talkadsBidAdapter.jsis using arrow functions withthisbound tonull. This upgrade changed something in the transpilation so that it now (correctly) fails. I have "fixed" it in this PR, but I did not verify my changes beyond the unit tests.plugins/RequireEnsureWithoutJsonp.jsdid not appear to have any effect; I tested it by replacing this line with gibberish (on master) and I could not find it anywhere in the build output. It is not compatible with webpack 5 so I removed it completely.sinon.stuband similar methods will refuse to work on es6 modules. This is the reason for forcing commonjs (via babel) and the refactoring ofevents.js.AnalyticsAdapter.jsis not included in prebid-core (this was explicit in master, and here that continues to be true because it's not imported fromsrc/prebid.js). This means that including multiple analytics adapters in a bundle will result in duplicated code (issue Bundle size inflated due to intra-module dependencies #7936).