Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTM bid adapter: use top origin as default domain #8004

Merged
merged 1 commit into from
Apr 22, 2022
Merged

OTM bid adapter: use top origin as default domain #8004

merged 1 commit into from
Apr 22, 2022

Conversation

regulyarniy
Copy link
Contributor

@regulyarniy regulyarniy commented Feb 3, 2022 •
edited
Loading

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

use top level origin as a default 'domain' argument for bid request

Other information

Need @krecu review as the OTM module maintainer
Need @ChrisHuie review

@regulyarniy regulyarniy marked this pull request as ready for review April 13, 2022 10:46
@regulyarniy
Copy link
Contributor Author

Need @ChrisHuie review

@regulyarniy regulyarniy marked this pull request as draft April 13, 2022 10:51
@regulyarniy regulyarniy marked this pull request as ready for review April 13, 2022 10:51
patmmccann
patmmccann requested changes Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have to use our methods

@regulyarniy regulyarniy requested a review from patmmccann April 14, 2022 04:07
@regulyarniy
Copy link
Contributor Author

regulyarniy commented Apr 14, 2022 •
edited
Loading

@patmmccann thx for the review! Could you please also look why the CI is failing? I think it's temporary problem with bs, nor the code problem.

@regulyarniy regulyarniy force-pushed the VNF-32 branch 2 times, most recently from 8ef46a0 to ad05b86 Compare April 18, 2022 08:59
@regulyarniy regulyarniy force-pushed the VNF-32 branch 3 times, most recently from ea5c456 to 83786f8 Compare April 21, 2022 22:22
@regulyarniy regulyarniy requested a review from patmmccann April 22, 2022 09:12
@patmmccann patmmccann merged commit 18612ab into prebid:master Apr 22, 2022
JoelPM pushed a commit to JoelPM/Prebid.js that referenced this pull request Apr 25, 2022
@regulyarniy @JoelPM
OTM bid adapter: use top origin as default domain (prebid#8004)
10d4b0e
@dgirardi dgirardi mentioned this pull request Apr 28, 2022
Merged
@saxsir saxsir mentioned this pull request Oct 5, 2022
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmmccann patmmccann patmmccann approved these changes

@krecu krecu krecu approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@regulyarniy @patmmccann @krecu