adomik Analytics Adapter: sampling revamp, add AB test info, enhance bidWon info #8122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liabas-b
changed the title
|
@liabas-b Please add associated unit tests as well! |
Work in progress :) |
liabas-b
force-pushed
the
adomik-adapter-save-won-bidresp
branch
from
e61ec14 to
8e05d27
Compare
Done @robertrmartinez and @lksharma. Any advice will be appreciated I'm no javascript specialist :) |
patmmccann
changed the title
|
@patmmccann @lksharma Hello, is anything still blocking the merge ? |
1 similar comment
|
@patmmccann @lksharma Hello, is anything still blocking the merge ? |
|
just review. @ChrisHuie ; could you investigate if this reviewer is on leave? |
ChrisHuie
approved these changes
Apr 13, 2022
JoelPM
pushed a commit
to JoelPM/Prebid.js
that referenced
this pull request
Apr 25, 2022
…bidWon info (prebid#8122) * Adomik Analytics Adapter: Save bid response of the won event * wip * adomikAnayticsAdapter/receive KV from sessionStorage * AdomikAnalyticsAdapter: add specs * kick off testing Co-authored-by: thomasferal <thomas.feral@adomik.com> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change