-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rubicon Analytics Adapter: pass along billing events #8182
Merged
ChrisHuie
merged 5 commits into
prebid:master
from
rubicon-project:rubiAnalytics-billingEvents
Mar 15, 2022
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
caa3bd6
rubicon listens to billing events
robertrmartinez 90a9d60
Merge branch 'prebid:master' into rubiAnalytics-billingEvents
robertrmartinez c52f0c9
billingId is required
robertrmartinez bf67841
Merge branch 'master' of https://github.com/prebid/Prebid.js into rub…
robertrmartinez 169eaa9
remove log
robertrmartinez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why cloning
cache.billing
just to log it? DoeslogInfo()
modify objects?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually a log I was using when doing some testing.
If you directly log the object it gets updated in the console as it gets updated, so at any one point of log I wanted it to show me what was there at that time. Prob should have just JSON stringified haha. Was not meant to be in final merge!
I will just remove this log.