-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prebid core: make GDPR/USP consent data available without requiring an auction #8185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgirardi Looks good overall and seems to work. There are a few places in the jsdoc comments where I think the function parameter names have not been updated.
modules/consentManagement.js
Outdated
@@ -38,8 +38,8 @@ const cmpCallMap = { | |||
* @param {function(string)} cmpError acts as an error callback while interacting with the config string; pass along an error message (string) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgirardi Can you please update the jsdocs blurbs so that it reflects the new API for the functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - I don't know how I completely missed that, thanks for pointing it out!
Type of change
Description of change
This extends #8071 to make access to GPDR/USP consent data possible even when no auction is started.
Use case: #7803