Vibrant Media Bid Adapter: onBidWon pixel trigger #8191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
reviewed
Mar 23, 2022
| @@ -213,7 +213,9 @@ export const spec = { | |||
| * @param {*} bidData the data associated with the won bid. See example above for data format. | |||
| */ | |||
| onBidWon: function(bidData) { | |||
| logInfo('Bid won: ' + JSON.stringify(bidData)); | |||
| if (bidData && bidData.meta && bidData.meta.wp) { | |||
| triggerPixel(`${bidData.meta.wp}${bidData.status}`); | |||
There was a problem hiding this comment.
can you make sure biddata.wp is a url?
There was a problem hiding this comment.
bidData.meta.wp is guaranteed to be a valid url, since it's an internal endpoint we use for reporting purposes (bids/won bids ratio and similar stats), generated server-side because we use several dynamic query string parameters in it.
We could add regex-based URL validation for bidData.meta.wp in the adapter though. Would that meet your expectations?
There was a problem hiding this comment.
@ChrisHuie should we go ahead and add regex-based URL validation to our adapter, to formally check bidData.meta.wp has the right format?
There was a problem hiding this comment.
@ChrisHuie updated accordingly, thanks :)
patmmccann
approved these changes
Apr 13, 2022
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Triggered Vibrant internal pixel endpoint on bidWon event handler
contact email of the adapter’s maintainer: kormorant@vibrantmedia.com
official adapter submission
Other information