Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DistroScale Bid Adapter #8221

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Add DistroScale Bid Adapter #8221

merged 2 commits into from
Apr 7, 2022

Conversation

duancg
Copy link
Contributor

@duancg duancg commented Mar 25, 2022

Type of change

  • New bidder adapter

Description of change

Adding a new DistroScale Bid Adapter.

  • test parameters for validating bids
[{
    code: 'div-gpt-ad-1460505748561-0',
    mediaTypes: {
        banner: {
            sizes: [[300, 250]],
        }
    },
    bids: [{
        bidder: 'distroscale',
        params: {
            pubid: '12345',
            zoneid: '67890'
        }
    }]
}]

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
This change does not change any API nor documentation other than the one dedicated to DistroScale Bid Adapter.

Other information

@lgtm-com
Copy link

lgtm-com bot commented Mar 25, 2022

This pull request introduces 1 alert when merging 0136296 into 64bd041 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@ncolletti
Copy link
Contributor

hey @duancg -- looks like your test fails with linting errors, could those be resolved?

Clean up code style issues
@duancg
Copy link
Contributor Author

duancg commented Apr 1, 2022

Hi @ncolletti , thanks for pointing it out, we linted the code and now it should pass all tests. and Here is the latest commit 61f768b . Should I file a new pull request or this request should suffice?

@ncolletti
Copy link
Contributor

@duancg The adapter looks great, nice work. Only thing I noticed is duplicate data being sent in your bid requests between tagid and zoneid, however, I presume that is intentional?

@ncolletti ncolletti merged commit 5406273 into prebid:master Apr 7, 2022
@duancg
Copy link
Contributor Author

duancg commented Apr 7, 2022

@duancg The adapter looks great, nice work. Only thing I noticed is duplicate data being sent in your bid requests between tagid and zoneid, however, I presume that is intentional?

Thanks for your comment! Yes, the information is replicated intentionally in two places for compatibility with some backend servers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants