-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AudienceRun Bid Adapter: Add Support for User Matching, Referer, … #8261
Conversation
@audiencerun can you please remove changes to the package-lock file 🙏 Looks to just be the updated prebid version release number. |
Hi @ChrisHuie, just restored the package-lock.json file. Thanks. |
* | ||
* @returns {string} | ||
*/ | ||
function getPageReferer() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this is being duplicated?
bidderRequest.refererInfo.referer
does this logic already, so not really sure this is needed.
https://github.com/prebid/Prebid.js/blob/master/src/refererDetection.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @robertrmartinez, it is not a duplicate as bidderRequest.refererInfo.referer
seems to return at first the URL of the page where Prebid.js is called while we need the URL that linked to this page and not the URL of the current page.
Here is a screen that shows it and is available at https://7buoei.csb.app/?pbjs_debug=true
Feel free if you need more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will be making a util function or add this to refererDetection in order to make sure adapters do not duplicate code. Thanks!
…rebid#8261) * AudienceRun Bid Adapter: Add Support for User Matching, Referer, US Privacy, Schain * fix: restore package-lock.json
Type of change
Description of change
Add Support for User Matching, Referer, Schain, US Privacy, GLVID
Other information
PR prebid/prebid.github.io#3687