Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudienceRun Bid Adapter: Add Support for User Matching, Referer, … #8261

Merged
merged 3 commits into from
Apr 18, 2022

Conversation

audiencerun
Copy link
Contributor

@audiencerun audiencerun commented Apr 5, 2022

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Add Support for User Matching, Referer, Schain, US Privacy, GLVID

Other information

PR prebid/prebid.github.io#3687

@audiencerun audiencerun marked this pull request as ready for review April 5, 2022 16:17
@ChrisHuie
Copy link
Collaborator

ChrisHuie commented Apr 6, 2022

@audiencerun can you please remove changes to the package-lock file 🙏 Looks to just be the updated prebid version release number.

@audiencerun
Copy link
Contributor Author

Hi @ChrisHuie, just restored the package-lock.json file. Thanks.

*
* @returns {string}
*/
function getPageReferer() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this is being duplicated?

bidderRequest.refererInfo.referer does this logic already, so not really sure this is needed.

https://github.com/prebid/Prebid.js/blob/master/src/refererDetection.js

Copy link
Contributor Author

@audiencerun audiencerun Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @robertrmartinez, it is not a duplicate as bidderRequest.refererInfo.referer seems to return at first the URL of the page where Prebid.js is called while we need the URL that linked to this page and not the URL of the current page.

Here is a screen that shows it and is available at https://7buoei.csb.app/?pbjs_debug=true

pWjdre9U

Feel free if you need more details.

Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will be making a util function or add this to refererDetection in order to make sure adapters do not duplicate code. Thanks!

@robertrmartinez robertrmartinez merged commit d9465ed into prebid:master Apr 18, 2022
JoelPM pushed a commit to JoelPM/Prebid.js that referenced this pull request Apr 25, 2022
…rebid#8261)

* AudienceRun Bid Adapter: Add Support for User Matching, Referer, US Privacy, Schain

* fix: restore package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants