Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdYouLike Bidder - Add size in video bid #8282

Merged
merged 48 commits into from
Apr 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
5fb2f8f
Merge remote-tracking branch 'origin/master'
guiann Apr 14, 2021
f07f989
Merge remote-tracking branch 'origin/master'
guiann Apr 30, 2021
7cf8fb1
add required clickurl in every native adrequest
guiann Apr 30, 2021
cb45b27
allows the native response to be given as is to prebid if possible
guiann May 25, 2021
c57af68
add unit tests on new Native case
guiann May 26, 2021
bfb6101
Merge branch 'forceClickUrl'
guiann May 26, 2021
df7e7bc
Merge remote-tracking branch 'origin/master'
guiann May 27, 2021
979dbb5
Merge remote-tracking branch 'origin/master'
guiann May 31, 2021
77000a4
Merge remote-tracking branch 'Adyoulike/master'
guiann May 31, 2021
00df091
Handle meta object in bid response with default addomains array
guiann May 31, 2021
9ed3845
Merge remote-tracking branch 'Adyoulike/master'
guiann Jun 1, 2021
97bd819
fix icon retrieval in Native case
guiann Jun 17, 2021
7897e6a
Update priorities in case of multiple mediatypes given
guiann Jun 17, 2021
9e8968b
merge master branch
guiann Jun 17, 2021
bbee6cc
improve robustness and fix associated unit test on picture urls
guiann Jun 17, 2021
0f3aa09
Merge remote-tracking branch 'origin/master'
guiann Jul 20, 2021
3e7201c
add support for params.size parameter
guiann Jul 20, 2021
89c5d24
Merge remote-tracking branch 'Adyoulike/master'
guiann Jul 20, 2021
13da01b
add unit test on new size format
guiann Jul 20, 2021
e87b7a9
Merge remote-tracking branch 'origin/master'
guiann Jul 26, 2021
dc609d7
Makes sure the playerSize format is consistent
guiann Jul 28, 2021
41198fc
Merge remote-tracking branch 'Adyoulike/master'
guiann Jul 28, 2021
8afe053
enable Vast response on bidder adapter
guiann Jul 28, 2021
d60f235
fix lint errors
guiann Jul 28, 2021
3315a72
Merge remote-tracking branch 'origin/master'
guiann Jul 28, 2021
bd7551f
add test on Vast format case
guiann Jul 28, 2021
055fe9f
Merge remote-tracking branch 'origin/master'
guiann Oct 27, 2021
55bae6b
Merge remote-tracking branch 'origin/master'
guiann Nov 2, 2021
95137ab
add userId to bidrequest
guiann Nov 3, 2021
ec8c460
Merge remote-tracking branch 'origin/master'
guiann Nov 3, 2021
cb9abdf
revert package-lock.json changes
guiann Nov 5, 2021
c0f845c
Merge remote-tracking branch 'origin/master'
guiann Nov 18, 2021
4c33eeb
Merge remote-tracking branch 'origin/master'
guiann Dec 15, 2021
ac0fafe
improve multiple mediatype handling
guiann Dec 16, 2021
65f1ce3
Expose adyoulike GVL id
guiann Feb 3, 2022
a64d24b
Merge remote-tracking branch 'Adyoulike/master'
guiann Feb 3, 2022
5964a79
fix icurl issue when retreiving icon for Native mediatype
guiann Feb 16, 2022
b83e886
update unit tests on icon url in native mediatype
guiann Feb 16, 2022
672bb56
Merge remote-tracking branch 'origin/master'
guiann Feb 16, 2022
48d7afa
Merge remote-tracking branch 'origin/master'
guiann Mar 9, 2022
d5a5bb0
target video endpoint when video mediatype is present
guiann Mar 9, 2022
85a0828
add unit test on video endpoint
guiann Mar 9, 2022
0da2460
detect if bid request has video
guiann Mar 10, 2022
5162ece
Merge remote-tracking branch 'origin/master'
guiann Mar 10, 2022
2ad1cc0
remove console log
guiann Mar 14, 2022
e28f64e
Merge remote-tracking branch 'origin/master'
guiann Mar 14, 2022
5550f5c
Merge remote-tracking branch 'origin/master'
guiann Apr 13, 2022
7b4e53b
Add size information in Video bid + unit tests
guiann Apr 13, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/adyoulikeBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,8 @@ function createBid(response, bidRequests) {
// retreive video response if present
const vast64 = response.Vast || getVideoAd(response);
if (vast64) {
bid.width = response.Width;
bid.height = response.Height;
bid.vastXml = window.atob(vast64);
bid.mediaType = 'video';
} else if (request.Native) {
Expand Down
7 changes: 5 additions & 2 deletions test/spec/modules/adyoulikeBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -462,21 +462,24 @@ describe('Adyoulike Adapter', function () {
'Placement': 'placement_0',
'Vast': 'PFZBU1Q+RW1wdHkgc2FtcGxlPC92YXN0Pg==',
'Price': 0.5,
'Height': 600,
'Height': 300,
'Width': 530
}];

const videoResult = [{
cpm: 0.5,
creativeId: undefined,
currency: 'USD',
height: 300,
netRevenue: true,
requestId: 'bid_id_0',
ttl: 3600,
mediaType: 'video',
meta: {
advertiserDomains: []
},
vastXml: '<VAST>Empty sample</vast>'
vastXml: '<VAST>Empty sample</vast>',
width: 530
}];

const responseWithMultiplePlacements = [
Expand Down