33Across user id sub-module: initial release #8335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add colon to error message Co-authored-by: macinjosh32 <macinjosh32@users.noreply.github.com>
patmmccann
changed the title
jlukas79
approved these changes
May 2, 2022
tpmn-admin
pushed a commit
to tpmn-admin/Prebid.js
that referenced
this pull request
May 9, 2022
* wip * Rename lexicon param url to apiUrl and remove envelope param * Rename gvlid spec title - lexicon id system * add missing semicolon * apply code review feedback lexicon id system * Unit test coverage for the callback execution - lexicon id system * Add lexicon to user id integration example * Add lexicon is system markdown documentation * Update modules/lexiconIdSystem.js add colon to error message Co-authored-by: macinjosh32 <macinjosh32@users.noreply.github.com> * Send privacy strings in the lexicon id system request * apply code review feedback markdown lexicon documentation * Rename files with references to lexicon * rename 33across ID from lexicon to 33acrossId * fix failing unit tests incorrect URL and error message * Add 33acrossId reference in submodules & documentation Co-authored-by: macinjosh32 <macinjosh32@users.noreply.github.com>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add 33across user id sub-module
Docs PR at prebid/prebid.github.io#3736
Other information
cc @jdwieland8282