Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price Floors Module: Support adUnit level floors #8396

Merged
merged 1 commit into from
May 10, 2022
Merged

Price Floors Module: Support adUnit level floors #8396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/priceFloors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@ export function getFirstMatchingFloor(floorData, bidObject, responseObject = {})
matchingData: allPossibleMatches[0], // the first possible match is an "exact" so contains all data relevant for anlaytics adapters
matchingRule
};
// use adUnit floorMin as priority!
if (typeof deepAccess(bidObject, 'ortb2Imp.ext.prebid.floorMin') === 'number') {
matchingData.floorMin = bidObject.ortb2Imp.ext.prebid.floorMin;
}
matchingData.matchingFloor = Math.max(matchingData.floorMin, matchingData.floorRuleValue);
// save for later lookup if needed
deepSetValue(floorData, `matchingInputs.${matchingInput}`, {...matchingData});
Expand Down
50 changes: 50 additions & 0 deletions test/spec/modules/priceFloors_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,56 @@ describe('the price floors module', function () {
matchingRule: undefined
});
});
it('correctly applies floorMin if on adunit', function () {
let inputFloorData = {
floorMin: 2.6,
currency: 'USD',
schema: {
delimiter: '|',
fields: ['adUnitCode']
},
values: {
'test_div_1': 1.0,
'test_div_2': 2.0
},
default: 0.5
};

let myBidRequest = { ...basicBidRequest };

// should take adunit floormin first even if lower
utils.deepSetValue(myBidRequest, 'ortb2Imp.ext.prebid.floorMin', 2.2);
expect(getFirstMatchingFloor(inputFloorData, myBidRequest, { mediaType: 'banner', size: '*' })).to.deep.equal({
floorMin: 2.2,
floorRuleValue: 1.0,
matchingFloor: 2.2,
matchingData: 'test_div_1',
matchingRule: 'test_div_1'
});
delete inputFloorData.matchingInputs;

// should take adunit floormin if higher
utils.deepSetValue(myBidRequest, 'ortb2Imp.ext.prebid.floorMin', 3.0);
expect(getFirstMatchingFloor(inputFloorData, myBidRequest, { mediaType: 'banner', size: '*' })).to.deep.equal({
floorMin: 3.0,
floorRuleValue: 1.0,
matchingFloor: 3.0,
matchingData: 'test_div_1',
matchingRule: 'test_div_1'
});
delete inputFloorData.matchingInputs;

// should take top floormin if no adunit floor min
delete myBidRequest.ortb2Imp;
expect(getFirstMatchingFloor(inputFloorData, myBidRequest, { mediaType: 'banner', size: '*' })).to.deep.equal({
floorMin: 2.6,
floorRuleValue: 1.0,
matchingFloor: 2.6,
matchingData: 'test_div_1',
matchingRule: 'test_div_1'
});
delete inputFloorData.matchingInputs;
});
it('selects the right floor for different mediaTypes', function () {
// banner with * size (not in rule file so does not do anything)
expect(getFirstMatchingFloor({...basicFloorData}, basicBidRequest, {mediaType: 'banner', size: '*'})).to.deep.equal({
Expand Down