AdxPremium analytics adapter: do not generate network activity after tests have completed #8514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
approved these changes
Jun 8, 2022
renebaudisch
pushed a commit
to renebaudisch/Prebid.js
that referenced
this pull request
Jun 28, 2022
…tests have completed (prebid#8514) * AdxPremium analytics adapter: do not generate network activity after tests have completed * Increase default test timeout to 3s
bwhisp
pushed a commit
to bwhisp/Prebid.js
that referenced
this pull request
Jul 13, 2022
…tests have completed (prebid#8514) * AdxPremium analytics adapter: do not generate network activity after tests have completed * Increase default test timeout to 3s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Update the adxpremium analytics adapter to not send queued events over the network if the adapter has been disabled by the time the queue is being processed. This should fix some spurious test failures like:
https://app.circleci.com/pipelines/github/prebid/Prebid.js/11695/workflows/73a3b5e6-a331-4246-b364-49a00552224e/jobs/22531