Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vrtcal Bid Adapter: added GDPR, CCPA, COPPA, and timeout passing support #8612

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Vrtcal Bid Adapter: added GDPR, CCPA, COPPA, and timeout passing support #8612

merged 1 commit into from
Jun 30, 2022

Conversation

vrtcal-dev
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ChrisHuie ChrisHuie changed the title Added GDPR, CCPA, COPPA, and timeout passing support Vrtcal Bid Adapter: added GDPR, CCPA, COPPA, and timeout passing support Jun 28, 2022
@ChrisHuie
Copy link
Collaborator

@vrtcal-dev can you please also submit an accompanying pr to our docs repo? https://github.com/prebid/prebid.github.io

@vrtcal-dev
Copy link
Contributor Author

vrtcal-dev commented Jun 28, 2022

@vrtcal-dev can you please also submit an accompanying pr to our docs repo? https://github.com/prebid/prebid.github.io

Thanks ChrisHuie. We actually already did, but had prematurely submitted before pushing the PBJS adapter updates
That pull request is: #3851 (It looks like this comment section is linking to the adapter itself, but please ref that pull # for the prebid.github.io repo.)

const params = {
prebidJS: 1,
prebidAdUnitCode: bid.adUnitCode,
id: bid.bidId,
tmax: tmax,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be bidderRequest.timeout. it's equivalent except when the publisher specifies the timeout manually with pbjs.requestBids({timeout: ...}), in which case this would miss it.

I don't know how much it matters since the correct timeout is enforced by core anyway - it depends on what the backend does with it.

@ChrisHuie ChrisHuie merged commit 0d49ff6 into prebid:master Jun 30, 2022
jlaso pushed a commit to AuDigent/Prebid.js that referenced this pull request Jul 1, 2022
Co-authored-by: Ubuntu <ubuntu@ip-172-31-25-92.us-west-1.compute.internal>
bwhisp pushed a commit to bwhisp/Prebid.js that referenced this pull request Jul 13, 2022
Co-authored-by: Ubuntu <ubuntu@ip-172-31-25-92.us-west-1.compute.internal>
ahmadlob referenced this pull request in taboola/Prebid.js Jul 27, 2022
Co-authored-by: Ubuntu <ubuntu@ip-172-31-25-92.us-west-1.compute.internal>
RomainLofaso pushed a commit to criteo-forks/Prebid.js that referenced this pull request Aug 8, 2022
Co-authored-by: Ubuntu <ubuntu@ip-172-31-25-92.us-west-1.compute.internal>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants