Add Sharethrough adapter #865

rizhang · 2016-12-08T02:23:07Z

Type of change

Description of change

test parameters for validating bids

{
  bidder: 'sharethrough',
  params: {
      pkey: 'DfFKxpkRGPMS7A9f71CquBgZ'
  }
}

contact email of the adapter’s maintainer
[rzhang@sharethrough.com] official adapter submission

Other information

Added Sharethrough Adapter

mkendall07 · 2016-12-14T21:19:25Z

src/adapters/sharethrough.js

+ bidmanager.addBidResponse(bidObj.placementCode, bid);
+ }
+
+ str.bidWon = function() {


We currently do not allow bidders to listen to other bids. If a bidder wants to do this, they should add an analytics adapter. This is a publisher opt in only process. https://github.com/prebid/Prebid.js/blob/master/src/adapters/analytics/example2.js

mkendall07 · 2016-12-14T21:21:52Z

src/adapters/sharethrough.js

+
+ const str = {};
+ str.STR_BTLR_HOST = document.location.protocol + "//btlr.sharethrough.com";
+ str.STR_TEST_HOST = document.location.protocol + "//btlr-prebid-test.sharethrough.com";


Using a different endpoint for test is not ideal as real issues are discovered in prod. Is there a way to not use a test endpoint here?

We have to use a test endpoint here to guarantee that a creative is always return from our exchange. If we used the real endpoint there's no way to guarantee that a DSP will always bid on the impression request.

Usually other bidders setup a test creative /placement on the live exchange. Is this possible?

mkendall07 · 2016-12-14T21:24:51Z

src/adapters/sharethrough.js

+ const bidRequest = bids[i];
+ str.placementCodeSet[bidRequest.placementCode] = bidRequest;
+ const scriptUrl = _buildSharethroughCall(bidRequest);
+ str.loadIFrame(scriptUrl);


Don't load JSONP inside an iframe. Use ajax.js or adLoader.loadScript() instead

We need to put the url inside an iframe so we can drop tracking cookies on publisher's page. This method work for iOS Safari since they block 3rd party cookies.

mkendall07 · 2016-12-14T21:26:52Z

src/adapters/sharethrough.js

+ sfp_js.src = "//native.sharethrough.com/assets/sfp.js";
+ sfp_js.type = 'text/javascript';
+ sfp_js.charset = 'utf-8';
+ window.top.document.getElementsByTagName('body')[0].appendChild(sfp_js);


window.top isn't safe to call directly, it should be in a try/catch. Additionally it should be avoided if possible to support SafeFrame in the future.

matthewlane · 2016-12-13T20:00:49Z

test/spec/adapters/sharethrough_spec.js

@@ -0,0 +1,269 @@
+import { expect } from 'chai';
+import Adapter from '../../../src/adapters/sharethrough';
+import adloader from '../../../src/adloader';


This doesn't seem to be used anywhere, is it needed?

matthewlane · 2016-12-14T18:10:50Z

src/adapters/sharethrough.js

+
+ function _receiveMessage(event) {
+ if(event.origin === str.STR_BTLR_HOST || event.origin === str.STR_TEST_HOST) {
+ $$PREBID_GLOBAL$$.strcallback(JSON.parse(event.data).response);


Please wrap JSON.parse in a try/catch block

matthewlane · 2016-12-14T18:13:00Z

src/adapters/sharethrough.js

+ try {
+ const bid = bidfactory.createBid(1, bidObj);
+
+ bid.bidderCode = 'sharethrough';


'sharethrough' is defined in STR_BIDDER_CODE, could use that here to avoid duplicating the string

mkendall07 · 2017-01-05T22:13:32Z

src/adapters/sharethrough.js

+ function _callBids(params) {
+ const bids = params.bids;
+
+ $$PREBID_GLOBAL$$.onEvent('bidWon', str.bidWon);


This line can be removed now that you added your analytics adapter.

mkendall07 · 2017-01-05T22:15:36Z

src/adapters/sharethrough.js

+ function _receiveMessage(event) {
+ if(event.origin === str.STR_BTLR_HOST || event.origin === str.STR_TEST_HOST) {
+ try {
+ $$PREBID_GLOBAL$$.strcallback(JSON.parse(event.data).response);


this doesn't need to a public function because it's scoped within the adapter itself. Only use a public function if you use JSONP.

mkendall07 · 2017-01-05T22:20:09Z

src/adapters/analytics/sharethrough_analytics.js

+import adapter from 'AnalyticsAdapter';
+const utils = require('../../utils');
+
+const url = 'https://httpbin.org/post';


You probably don't want to be sending data to httpbin.org

matthewlane · 2017-01-05T22:37:39Z

package.json

@@ -17,7 +17,7 @@
 "prebid"
 ],
 "globalVarName": "pbjs",
- "analytics": [],
+ "analytics": ["sharethrough_analytics"],


Analytics is explicitly turned on by the publisher so this array should be blank by default

rizhang · 2017-01-10T21:18:38Z

I updated the test pkey parameter

mkendall07 · 2017-01-12T15:41:17Z

@matthewlane just need final review for bids back on this one.

matthewlane

Validated bids come back

* Rz/submit to prebid (#4) Added Sharethrough Adapter * fix warnings * added beacons * made compatible with chrome 37. other minor changes * win beacon fired in analytics adapter * specs for new analytics adapter * add try catch blocks. misc refactor * removed test page * remove debugger * refactor analytics adapter * removed test endpoint * analytics url parameter is empty * removed bidwon listener on adapter * removed analytics from package.json

* refactored the way hb_deal is handled in adserverTargeting * Add Sharethrough adapter (#865) * Rz/submit to prebid (#4) Added Sharethrough Adapter * fix warnings * added beacons * made compatible with chrome 37. other minor changes * win beacon fired in analytics adapter * specs for new analytics adapter * add try catch blocks. misc refactor * removed test page * remove debugger * refactor analytics adapter * removed test endpoint * analytics url parameter is empty * removed bidwon listener on adapter * removed analytics from package.json * refactor hb_deal targeting key as a standard key * rollback errant style fixes * more fixes

…ebid-official-0.18.0 to release/1.13.0 * commit 'e145489bc5dd6d292cf16e7fe80adfdf991562ac': (27 commits) Add changelog entry. Prebid 0.18.0 Release Add Criteo adapter (prebid#928) add an event that fires when requestBids is called (prebid#939) Xaxis adapter submitted by Daniel hoffmann (prebid#938) Add flash detection to TripleLift adapter (prebid#855) OpenX Adapter: Fixed bug regarding cross-domain iframe support (prebid#931) Emit event when setTargetingForGPTAsync is called (prebid#873) Maintenance/refactor hb deal (prebid#935) Reset hb_* keys only for registered aduniits (prebid#934) update code style - smartyads adapter Catch errors in bidsBackHandler. Also fix test cleanup in pbjs api spec. (prebid#905) Smartyads Adapter (prebid#895) Appnexus targeting function (prebid#920) There are 2 changes- (prebid#913) Adding support for all AST parameters (prebid#923) GumGum adapter - include the bid timeout as `tmax` (prebid#908) Add pixel size (prebid#892) enable postMessage listener for cross-domain iframe support (prebid#885) Add Sharethrough adapter (prebid#865) ...

…13.0 to master * commit '7d32ed18c8636d9241ef8b299b6abd885536db69': (27 commits) Add changelog entry. Prebid 0.18.0 Release Add Criteo adapter (prebid#928) add an event that fires when requestBids is called (prebid#939) Xaxis adapter submitted by Daniel hoffmann (prebid#938) Add flash detection to TripleLift adapter (prebid#855) OpenX Adapter: Fixed bug regarding cross-domain iframe support (prebid#931) Emit event when setTargetingForGPTAsync is called (prebid#873) Maintenance/refactor hb deal (prebid#935) Reset hb_* keys only for registered aduniits (prebid#934) update code style - smartyads adapter Catch errors in bidsBackHandler. Also fix test cleanup in pbjs api spec. (prebid#905) Smartyads Adapter (prebid#895) Appnexus targeting function (prebid#920) There are 2 changes- (prebid#913) Adding support for all AST parameters (prebid#923) GumGum adapter - include the bid timeout as `tmax` (prebid#908) Add pixel size (prebid#892) enable postMessage listener for cross-domain iframe support (prebid#885) Add Sharethrough adapter (prebid#865) ...

rizhang added 4 commits December 7, 2016 18:18

Rz/submit to prebid (#4)

24ccb34

Added Sharethrough Adapter

fix warnings

ea63844

added beacons

10c6672

made compatible with chrome 37. other minor changes

09bbd04

matthewlane added the needs review label Dec 12, 2016

matthewlane self-assigned this Dec 12, 2016

mkendall07 requested changes Dec 14, 2016

View reviewed changes

mkendall07 added needs update and removed needs review labels Dec 14, 2016

matthewlane reviewed Dec 14, 2016

View reviewed changes

rizhang added 8 commits December 27, 2016 18:29

win beacon fired in analytics adapter

1f59313

specs for new analytics adapter

9f5ca43

add try catch blocks. misc refactor

6283cf3

Merge branch 'master' of https://github.com/prebid/Prebid.js

3b9328a

Merge branch 'master' into rz/str_test_version

4664f08

removed test page

aaa8acc

remove debugger

5d68e90

refactor analytics adapter

83f7765

mkendall07 requested changes Jan 5, 2017

View reviewed changes

mkendall07 reviewed Jan 5, 2017

View reviewed changes

matthewlane reviewed Jan 5, 2017

View reviewed changes

matthewlane added this to the Prebid 0.18.0 milestone Jan 6, 2017

rizhang added 4 commits January 10, 2017 12:33

removed test endpoint

1048b22

analytics url parameter is empty

acf430d

removed bidwon listener on adapter

699412f

removed analytics from package.json

fff53f1

mkendall07 approved these changes Jan 12, 2017

View reviewed changes

mkendall07 added needs review and removed needs update labels Jan 12, 2017

matthewlane removed the needs review label Jan 12, 2017

matthewlane approved these changes Jan 12, 2017

View reviewed changes

matthewlane merged commit a42655b into prebid:master Jan 12, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Sharethrough adapter #865

Add Sharethrough adapter #865

rizhang commented Dec 8, 2016 •

edited

Loading

mkendall07 Dec 14, 2016

mkendall07 Dec 14, 2016

rizhang Dec 27, 2016

mkendall07 Jan 5, 2017

mkendall07 Dec 14, 2016

rizhang Dec 28, 2016

mkendall07 Jan 5, 2017

mkendall07 Dec 14, 2016

matthewlane Dec 13, 2016

matthewlane Dec 14, 2016

matthewlane Dec 14, 2016

mkendall07 Jan 5, 2017

mkendall07 Jan 5, 2017

mkendall07 Jan 5, 2017

matthewlane Jan 5, 2017

rizhang commented Jan 10, 2017 •

edited

Loading

mkendall07 commented Jan 12, 2017

matthewlane left a comment

Add Sharethrough adapter #865

Add Sharethrough adapter #865

Conversation

rizhang commented Dec 8, 2016 • edited Loading

Type of change

Description of change

Other information

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rizhang commented Jan 10, 2017 • edited Loading

mkendall07 commented Jan 12, 2017

matthewlane left a comment

Choose a reason for hiding this comment

rizhang commented Dec 8, 2016 •

edited

Loading

rizhang commented Jan 10, 2017 •

edited

Loading