-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prisma Bid Adapter: initial bid adapter release #8681
Conversation
Docs pr -> prebid/prebid.github.io#3898 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adapter submission is nearly identical to nexx360
-- Both share the same domain for endpoints, with separate subdomains. Instead of adding a new adapter, has your team considered adding a new alias for primsa
, when used it would use prisma subdomains for requests.
I agree the adapter is currently quite identical for now as the |
bidResponses.meta.advertiserDomains defaulted to []
Not necessary for now
Looks good, could your docs PR reflect the removal of bidfloor and bidfloorCurrency, will merge in when updated |
Hi @ncolletti , it's done :) Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* prisma adapter added * bidResponses.meta.advertiserDomains update bidResponses.meta.advertiserDomains defaulted to [] * VideoExt removed from buildRequest Not necessary for now * Price floor removed * Floor and keyword tests removed
* prisma adapter added * bidResponses.meta.advertiserDomains update bidResponses.meta.advertiserDomains defaulted to [] * VideoExt removed from buildRequest Not necessary for now * Price floor removed * Floor and keyword tests removed
* prisma adapter added * bidResponses.meta.advertiserDomains update bidResponses.meta.advertiserDomains defaulted to [] * VideoExt removed from buildRequest Not necessary for now * Price floor removed * Floor and keyword tests removed
* prisma adapter added * bidResponses.meta.advertiserDomains update bidResponses.meta.advertiserDomains defaulted to [] * VideoExt removed from buildRequest Not necessary for now * Price floor removed * Floor and keyword tests removed
Type of change
Description of change
Prisma Bid Adapter added
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
https://github.com/prebid/prebid.github.io/pull/3898
Other information