Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prisma Bid Adapter: initial bid adapter release #8681

Merged
merged 5 commits into from
Jul 21, 2022

Conversation

gchicoye
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • [ X] New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Prisma Bid Adapter added

  • test parameters for validating bids
{
  bidder: 'prisma',
  params: {
      account: '1067',
      tagId: 'luvxjvgn'
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • [ X] official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ChrisHuie ChrisHuie requested a review from ncolletti July 13, 2022 14:40
@ChrisHuie ChrisHuie changed the title Prisma Bid Adapter: add new bid adapter Prisma Bid Adapter: initial bid adapter release Jul 14, 2022
@ChrisHuie
Copy link
Collaborator

Docs pr -> prebid/prebid.github.io#3898

Copy link
Contributor

@ncolletti ncolletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adapter submission is nearly identical to nexx360 -- Both share the same domain for endpoints, with separate subdomains. Instead of adding a new adapter, has your team considered adding a new alias for primsa, when used it would use prisma subdomains for requests.

modules/prismaBidAdapter.js Outdated Show resolved Hide resolved
modules/prismaBidAdapter.js Outdated Show resolved Hide resolved
modules/prismaBidAdapter.js Outdated Show resolved Hide resolved
@gchicoye
Copy link
Contributor Author

This adapter submission is nearly identical to nexx360 -- Both share the same domain for endpoints, with separate subdomains. Instead of adding a new adapter, has your team considered adding a new alias for primsa, when used it would use prisma subdomains for requests.

I agree the adapter is currently quite identical for now as the nexx360 one. As you can imagine, we indeed have considered using aliases. However, this is just a starting point, as we plan to have specific features which will strongly defer from one adapter to the other (on both client and server side), so the Prisma adapter creation was made on purpose. In addition, the main reason why we're reusing nexx360.io domain is to leverage on the cookie sync already performed.

@ncolletti
Copy link
Contributor

Looks good, could your docs PR reflect the removal of bidfloor and bidfloorCurrency, will merge in when updated

@gchicoye
Copy link
Contributor Author

Hi @ncolletti , it's done :) Thanks!

Copy link
Contributor

@ncolletti ncolletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ncolletti ncolletti added the LGTM label Jul 21, 2022
@ncolletti ncolletti merged commit 2684aa3 into prebid:master Jul 21, 2022
ahmadlob referenced this pull request in taboola/Prebid.js Jul 27, 2022
* prisma adapter added

* bidResponses.meta.advertiserDomains update

bidResponses.meta.advertiserDomains defaulted to []

* VideoExt removed from buildRequest

Not necessary for now

* Price floor removed

* Floor and keyword tests removed
ccorbo pushed a commit to ccorbo/Prebid.js that referenced this pull request Jul 27, 2022
* prisma adapter added

* bidResponses.meta.advertiserDomains update

bidResponses.meta.advertiserDomains defaulted to []

* VideoExt removed from buildRequest

Not necessary for now

* Price floor removed

* Floor and keyword tests removed
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
* prisma adapter added

* bidResponses.meta.advertiserDomains update

bidResponses.meta.advertiserDomains defaulted to []

* VideoExt removed from buildRequest

Not necessary for now

* Price floor removed

* Floor and keyword tests removed
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
* prisma adapter added

* bidResponses.meta.advertiserDomains update

bidResponses.meta.advertiserDomains defaulted to []

* VideoExt removed from buildRequest

Not necessary for now

* Price floor removed

* Floor and keyword tests removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants