FTRACK UserId Submodule: adding more tests for the get ID methods in pbjs #8737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
changed the title
|
We love extra test PRs, ty! |
|
@patmmccann I think this is ready to roll. Do we think it would be helpful if there was a comment in the User Id submodule build directions asking folks to include tests for |
|
It seems wise if the return structure is complicated, like yours or @Nick-Merkle |
1 task
|
@patmmccann Added a PR to the documentation prebid/prebid.github.io#3929 |
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
…pbjs (prebid#8737) * FTRACK: adding more tests for the get ID methods in pbjs * FTRACK: making the tests a little DRYer * FTRACK: cleaning up the tests * FTRACK: cleaning up some comments Co-authored-by: Jason Lydon <jason.lydon@flashtalking.com>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
…pbjs (prebid#8737) * FTRACK: adding more tests for the get ID methods in pbjs * FTRACK: making the tests a little DRYer * FTRACK: cleaning up the tests * FTRACK: cleaning up some comments Co-authored-by: Jason Lydon <jason.lydon@flashtalking.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
pbjs.getUserIdsAsEids(), we realized we also lacked tests forpbjs.getUserIdsAsync()andpbjs.getUserIds()Other information