Taboola Bid Adapter: dynamic ttl #8747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update-ttl-passing
patmmccann
reviewed
Jul 27, 2022
| it('should set the correct ttl form the response', function () { | ||
| // set exp-ttl to be 125 | ||
| const [bid] = serverResponse.body.seatbid[0].bid; | ||
| serverResponse.body.seatbid[0].bid[0].exp = 125 |
There was a problem hiding this comment.
fixed - added semicolon
There was a problem hiding this comment.
in the lines below as well, our lgtm ends up flagging missing semicolons
There was a problem hiding this comment.
tyvm, please note the trailing spaces causing the failed linting checks
patmmccann
reviewed
Jul 27, 2022
patmmccann
approved these changes
Jul 28, 2022
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* update-ttl-passing * Update taboolaBidAdapter_spec.js * add fallback default value in case of null * add semicolons * . * . * . * .. * ...
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* update-ttl-passing * Update taboolaBidAdapter_spec.js * add fallback default value in case of null * add semicolons * . * . * . * .. * ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
editing a specific attribute passing mechanism in the adapter file + adding unit test for the change.