UserID Module: continue the auction if userId init fails #8788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
changed the title
|
@jlustig11 fyi, might be related to #8770 |
|
Thanks Patrick. @dgirardi I agree with your fix here, certainly better to continue the auction. Is the userID failing logged somewhere Regardless @patmmccann thanks for the mention. When this is merged Magnite can help test that version of Prebid. |
|
@jlustig11 any help on the path to merge would be much appreciated |
robertrmartinez
approved these changes
Aug 5, 2022
patmmccann
approved these changes
Aug 9, 2022
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
If the userId initialization logic fails, it silently stops the auction from running. In theory with #8401 errors from ID submodules should be handled gracefully, but I think it's better to continue the auction regardless (possibly without any IDs) if some other part of the logic throws.