Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHTNW Adapter: initial release #8987

Merged
merged 4 commits into from
Oct 21, 2022
Merged

CHTNW Adapter: initial release #8987

merged 4 commits into from
Oct 21, 2022

Conversation

chtdsp
Copy link
Contributor

@chtdsp chtdsp commented Sep 13, 2022 •
edited
Loading

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • [ ] Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Add chtnwBidAdapter

  • contact email of the adapter’s maintainer chtdsp@cht.com.tw
  • test parameters for validating bids:
bids: [{
    bidder: 'chtnw',
    params: {
        placementId: '38EL412LO82XR9O6'
    }
}]

@chtdsp chtdsp mentioned this pull request Sep 13, 2022
Merged
8 tasks
@jsnellbaker jsnellbaker requested a review from osazos September 13, 2022 17:16
@chtdsp
Copy link
Contributor Author

chtdsp commented Sep 26, 2022

Hi @patmmccann, we have updated please review again.

@MartianTribe
Copy link

Docs PR: prebid/prebid.github.io#4016

@ChrisHuie ChrisHuie removed the request for review from osazos September 27, 2022 18:28
@ChrisHuie ChrisHuie assigned patmmccann and unassigned osazos Sep 27, 2022
@chtdsp chtdsp requested a review from patmmccann September 28, 2022 01:28
@ChrisHuie ChrisHuie requested review from ChrisHuie and removed request for patmmccann October 18, 2022 15:16
@ChrisHuie ChrisHuie assigned ChrisHuie and unassigned patmmccann Oct 18, 2022
@ChrisHuie
Copy link
Collaborator

ChrisHuie commented Oct 18, 2022 •
edited
Loading

@chtdsp i don't see you support advertiserDomain. Can you please include handling for adomain in this new adapter? Also pretty please pull in recent commits. This pr is a bit behind master 🙏

@chtdsp
Copy link
Contributor Author

chtdsp commented Oct 21, 2022

@chtdsp i don't see you support advertiserDomain. Can you please include handling for adomain in this new adapter? Also pretty please pull in recent commits. This pr is a bit behind master 🙏

Hi @ChrisHuie, I merged recent commits and update the advertiserDomain support. Thnaks.

@ChrisHuie ChrisHuie merged commit 6c63c6f into prebid:master Oct 21, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
@chtdsp @JacobKlein26
CHTNW Adapter: initial release (prebid#8987)
16e26f6 
* add chtnw bid adapter

* fix chtnw bid adapter issues

* add meta advertiserDomain support
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
@chtdsp @jorgeluisrocha
CHTNW Adapter: initial release (prebid#8987)
0d1d719 
* add chtnw bid adapter

* fix chtnw bid adapter issues

* add meta advertiserDomain support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmmccann patmmccann patmmccann left review comments

@ChrisHuie ChrisHuie ChrisHuie approved these changes

Assignees

@ChrisHuie ChrisHuie

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chtdsp @MartianTribe @ChrisHuie @patmmccann @osazos @jsnellbaker