Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AndBeyond.Media adapter: update bidder code #9005

Merged
merged 9 commits into from
Oct 6, 2022
Merged

AndBeyond.Media adapter: update bidder code #9005

merged 9 commits into from
Oct 6, 2022

Conversation

AndBeyondMediaHB
Copy link
Contributor

patmmccann
patmmccann requested changes Sep 16, 2022
View reviewed changes
modules/andBeyondMediaBidAdapter.js Outdated
@@ -4,7 +4,7 @@ import { registerBidder } from '../src/adapters/bidderFactory.js';
import { BANNER, NATIVE, VIDEO } from '../src/mediaTypes.js';
import { config } from '../src/config.js';

const BIDDER_CODE = 'beyondmedia';
const BIDDER_CODE = 'andbeyond.media';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very long, why not andbeyond

Copy link
Collaborator

@patmmccann patmmccann Sep 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also breaking i believe, add your old code as an alias

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very long, why not andbeyond

The thing is that this is a full name of the Company and we cannot shorten this to andbeyond. I haven't seen any limitations before. Do you have any?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GAM key values have a limit of 20 chars. And GET requests have a length limit. This can cause issues for publishers which use enableSendAll key values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patmmccann @muuki88
We have changed the code to "andbeyond". This is fine ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patmmccann @muuki88 we noticed that biddercode andbeyond is an Adkernel adapter alias, is that normal?https://github.com/AndBeyondMediaHB/Prebid.js/blob/master/modules/adkernelBidAdapter.js#L82

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patmmccann @muuki88
image

Are these rules valid? If so, can we use the biddercode andbeyondmedia. If not, why not?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well in this case you would not be unique with adkernel's alias for the first 6 characters. Did you discover why they are using your name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patmmccann They are using this name because this is a name of their company, they cannot change it to another one. Could you please clarify if it can cause some problems when this is not unique with adkernel's alias?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AdKernel's company name is also andbeyond?

@patmmccann patmmccann self-assigned this Sep 16, 2022
@bretg bretg mentioned this pull request Sep 26, 2022
Closed
@AndBeyondMediaHB AndBeyondMediaHB requested review from muuki88 and patmmccann and removed request for muuki88 and patmmccann September 27, 2022 09:36
patmmccann
patmmccann requested changes Sep 29, 2022
View reviewed changes
test/spec/modules/andbeyondmediaBidAdapter_spec.js Outdated
@@ -3,7 +3,7 @@ import { spec } from '../../../modules/andBeyondMediaBidAdapter.js';
import { BANNER, VIDEO, NATIVE } from '../../../src/mediaTypes.js';
import { getUniqueIdentifierStr } from '../../../src/utils.js';

const bidder = 'beyondmedia'
const bidder = 'andbeyondmedia'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see the circleci failures

@AndBeyondMediaHB
Copy link
Contributor Author

@patmmccann @muuki88 we left the bidder code as is. We just changed the title and renamed the js-files to fix the upload issue

@AndBeyondMediaHB AndBeyondMediaHB requested review from muuki88 and removed request for muuki88 October 4, 2022 13:00
bretg
bretg requested changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok - changing the biddercode to "beyondmedia" for Prebid.js will solve the website download problem, but now you've introduced another problem -- you're not matching the biddercode for your server-side adapter.

I'm afraid I have to insist that your client-side and server-side bidder code match. Publishers need to be able to use the Server-to-Server testing module, which they wouldn't be able to do for your service if you've got different codes for these adapters. Let's get this right.

Will let you choose whether to use "beyondmedia" or "andbeyondmedia" - just settle on one please. And if desired, you can define an alias on either or both client- and server-sides to use both names!

@AndBeyondMediaHB
Copy link
Contributor Author

ok - changing the biddercode to "beyondmedia" for Prebid.js will solve the website download problem, but now you've introduced another problem -- you're not matching the biddercode for your server-side adapter.

I'm afraid I have to insist that your client-side and server-side bidder code match. Publishers need to be able to use the Server-to-Server testing module, which they wouldn't be able to do for your service if you've got different codes for these adapters. Let's get this right.

Will let you choose whether to use "beyondmedia" or "andbeyondmedia" - just settle on one please. And if desired, you can define an alias on either or both client- and server-sides to use both names!

@bretg @muuki88 @patmmccann Thanks, we decided to keep the name beyondmedia.
prebid/prebid-server#2408

@AndBeyondMediaHB AndBeyondMediaHB requested review from bretg and removed request for patmmccann October 6, 2022 09:32
@bretg
Copy link
Collaborator

bretg commented Oct 6, 2022

Question: should the adkernel adapter still be aliasing andbeyond?

@bretg bretg mentioned this pull request Oct 6, 2022
Merged
@AndBeyondMediaHB
Copy link
Contributor Author

Question: should the adkernel adapter still be aliasing andbeyond?

@bretg we are not affiliated with adkernel adapter, also we don't know if it should use andbeyond alias

@patmmccann patmmccann mentioned this pull request Oct 6, 2022
Merged
1 task
@patmmccann patmmccann merged commit f407e47 into prebid:master Oct 6, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
@AndBeyondMediaHB @vladis-teqblaze @JacobKlein26
AndBeyond.Media adapter: update bidder code (prebid#9005)
d2c9022 
* add andBeyondMedia adapter

* update bidderCode

* update biddercode

* change  andbeyond.media => andbeyond

* changes

* updates

* rename files

* updates

Co-authored-by: Vlad Isaiko <vladis@smartyads.com>
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
@AndBeyondMediaHB @vladis-teqblaze @jorgeluisrocha
AndBeyond.Media adapter: update bidder code (prebid#9005)
c5738d3 
* add andBeyondMedia adapter

* update bidderCode

* update biddercode

* change  andbeyond.media => andbeyond

* changes

* updates

* rename files

* updates

Co-authored-by: Vlad Isaiko <vladis@smartyads.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuki88 muuki88 muuki88 left review comments

@bretg bretg bretg approved these changes

@patmmccann patmmccann patmmccann approved these changes

Assignees

@patmmccann patmmccann

Labels
maintenance needs update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AndBeyondMediaHB @bretg @muuki88 @patmmccann @vladis-teqblaze