-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core & multiple modules: introduce new bidRejected
event, and refactor bid rejection logic
#9013
Conversation
bidRejected
events, and refactor bid rejection logicbidRejected
event, and refactor bid rejection logic
8e8d6ae
to
378e66a
Compare
@Fawke @ncolletti I know you guys have a few other pr reviews. Do either of you need me to reassign this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good at a first glance. I was able to simulate an invalid bid and could see the bidRejected
event fire.
I agree with the removal of the banner size check from targeting, and moving it as a separate check in Bidder Factory.
Rest, all looks good. I think making a note of this new event somewhere in the docs will be helpful for the Analytics adapters and other third party listeners.
I'm getting this error after this update
|
@lgadzhev-devrix is it similar to #9245? the author there concluded that the culprit was a browser extension. If your case is different could you open an issue and provide steps to reproduce? |
Yep, it was caused by the AdWizard on my end. Thank you! I'm not sure why
I couldn't find this issue while googling the error
|
…tor bid rejection logic (prebid#9013) * Separate code path for bid rejection * Client side bidder rejections * Rejection reasons in constants.json * PBS rejections * priceFloors * currency * Filter out NO_BID bids from targeting * Reject bids whose size does not match the request * Do not allow PBS stored impressions to go through without allowUnknownBidderCodes
…tor bid rejection logic (prebid#9013) * Separate code path for bid rejection * Client side bidder rejections * Rejection reasons in constants.json * PBS rejections * priceFloors * currency * Filter out NO_BID bids from targeting * Reject bids whose size does not match the request * Do not allow PBS stored impressions to go through without allowUnknownBidderCodes
Type of change
Description of change
This:
bidRejected
event, emitted when an adapter returns a bid response that core decides should not be usedsizeConfig
#8887)Other information
Closes #8956
Closes #8887