Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core & multiple modules: introduce new bidRejected event, and refactor bid rejection logic #9013

Merged
merged 10 commits into from
Oct 11, 2022

Conversation

dgirardi
Copy link
Collaborator

Type of change

  • Bugfix
  • Feature

Description of change

This:

Other information

Closes #8956
Closes #8887

@dgirardi dgirardi changed the title Core & multiple modules: introduce new bidRejected events, and refactor bid rejection logic Core & multiple modules: introduce new bidRejected event, and refactor bid rejection logic Sep 16, 2022
@dgirardi dgirardi marked this pull request as ready for review September 16, 2022 19:33
@ChrisHuie
Copy link
Collaborator

@Fawke @ncolletti I know you guys have a few other pr reviews. Do either of you need me to reassign this one?

Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at a first glance. I was able to simulate an invalid bid and could see the bidRejected event fire.

I agree with the removal of the banner size check from targeting, and moving it as a separate check in Bidder Factory.

Rest, all looks good. I think making a note of this new event somewhere in the docs will be helpful for the Analytics adapters and other third party listeners.

@lgadzhev-devrix
Copy link

I'm getting this error after this update

Exception in queued GPT command TypeError: e.getStatusCode is not a function

@dgirardi
Copy link
Collaborator Author

dgirardi commented Jan 9, 2023

@lgadzhev-devrix is it similar to #9245? the author there concluded that the culprit was a browser extension. If your case is different could you open an issue and provide steps to reproduce?

@lgadzhev-devrix
Copy link

lgadzhev-devrix commented Jan 10, 2023 via email

JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
…tor bid rejection logic (prebid#9013)

* Separate code path for bid rejection

* Client side bidder rejections

* Rejection reasons in constants.json

* PBS rejections

* priceFloors

* currency

* Filter out NO_BID bids from targeting

* Reject bids whose size does not match the request

* Do not allow PBS stored impressions to go through without allowUnknownBidderCodes
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
…tor bid rejection logic (prebid#9013)

* Separate code path for bid rejection

* Client side bidder rejections

* Rejection reasons in constants.json

* PBS rejections

* priceFloors

* currency

* Filter out NO_BID bids from targeting

* Reject bids whose size does not match the request

* Do not allow PBS stored impressions to go through without allowUnknownBidderCodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants