-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vuukle Bid Adapter: support gdpr/usp/coppa/schain/gvlid #9023
Conversation
Do we need to fix something or CircleCI error unrelated to our changes? |
Hey @Hamper I don't see a reason why your code is causing the circleci errors. If you try another arbitrary commit it should trigger another build and we can see if the errors are consistent or go away. |
Let me double check this pr today. Might be my fault it isn't passing tests. |
Tests fixed in original PR #8957 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, working in testing for me as well.
* add gdpr/usp/coppa/schain/gvlid * restore getConfig * fix linting
* add gdpr/usp/coppa/schain/gvlid * restore getConfig * fix linting
Resubmit of pr #8957
Docs update -> prebid/prebid.github.io#4003