Eplanning Bid Adapter: add support for video #9044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fndigrazia looks like there are some unit tests failing if you can check. |
|
Hello @ChrisHuie, thanks for creating the pr. The tests failed because you have to delete line 121 "ad: ad.adm,". In the original pr that line was deleted. |
Fixed. Thanks 🙏 |
osazos
approved these changes
Oct 10, 2022
| function cleanName(name) { | ||
| return name.replace(/_|\.|-|\//g, '').replace(/\)\(|\(|\)|:/g, '_').replace(/^_+|_+$/g, ''); | ||
| } | ||
|
|
||
| function getSpaces(bidRequests, ml) { | ||
| let impType = bidRequests.reduce((previousBits, bid) => (bid.mediaTypes && bid.mediaTypes[VIDEO]) ? (bid.mediaTypes[VIDEO].context == 'outstream' ? (previousBits | 2) : (previousBits | 1)) : previousBits, 0); |
There was a problem hiding this comment.
Not required, but for better readability, would you want to replace the part
bid.mediaTypes[VIDEO].context == 'outstream' ? (previousBits | 2) : (previousBits | 1)
by
bid.mediaTypes[VIDEO].context == 'outstream' ? (previousBits | VAST_OUTSTREAM) : (previousBits | VAST_INSTREAM)
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* add video * move up imptypes logic * fix linting * update curly braces * fix spaces linting * fix line
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* add video * move up imptypes logic * fix linting * update curly braces * fix spaces linting * fix line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmit of pr #9020