IX Bid Adapter: send bid floor per size in format ext #9084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
changed the title
|
please title your prs on your module with your module name |
Hey Pat, for sure. Thank you for making the title change. Was going to mark the PR as ready for review and update it but thanks! |
shahinrahbariasl
changed the title
shahinrahbariasl
changed the title
ChrisHuie
changed the title
patmmccann
reviewed
Oct 14, 2022
|
|
||
| // add floor per size | ||
| if ('bidfloor' in impressionObjects[i]) { | ||
| _bannerImpression.banner.format[i].ext.bidfloor = impressionObjects[i].bidfloor |
There was a problem hiding this comment.
Do you want currency here?
There was a problem hiding this comment.
Hey Pat, not for now. Currency will be the same for all sizes and at imp level. We're only going to add support for floors per size for now.
There was a problem hiding this comment.
@patmmccann Is there anything else you need from our end before merging?
patmmccann
approved these changes
Oct 19, 2022
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* feat: send bid floor per size in format ext [PB-1311] * fix: remove typo [PB-1311] Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* feat: send bid floor per size in format ext [PB-1311] * fix: remove typo [PB-1311] Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
For more information contact shahin.rahbariasl@indexexchange.com