Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBS Bid Adapter: alias Fix #9100

Merged
merged 2 commits into from
Oct 18, 2022
Merged

PBS Bid Adapter: alias Fix #9100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
466c4ad
Added adjustment for aliasing unregistered bidders for server-side
RRSchweitzer Oct 17, 2022
925ef36
removed import
RRSchweitzer Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/prebidServerBidAdapter/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ Object.assign(ORTB2.prototype, {
const bidder = adapterManager.bidderRegistry[bid.bidder];
// adding alias only if alias source bidder exists and alias isn't configured to be standalone
// pbs adapter
if (bidder && !bidder.getSpec().skipPbsAliasing) {
if (!bidder || !bidder.getSpec().skipPbsAliasing) {
aliases[bid.bidder] = adapterManager.aliasRegistry[bid.bidder];
}
}
Expand Down
24 changes: 24 additions & 0 deletions test/spec/modules/prebidServerBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1466,6 +1466,30 @@ describe('S2S Adapter', function () {
});
});

it('unregistered bidder should alias', function () {
const adjustedConfig = utils.deepClone(CONFIG);
adjustedConfig.bidders = 'bidderD'
config.setConfig({ s2sConfig: adjustedConfig });

const aliasBidder = {
bidder: 'bidderD',
params: {
unit: '10433394',
}
};

$$PREBID_GLOBAL$$.aliasBidder('mockBidder', aliasBidder.bidder);

const request = utils.deepClone(REQUEST);
request.ad_units[0].bids = [aliasBidder];
request.s2sConfig = adjustedConfig;

adapter.callBids(request, BID_REQUESTS, addBidResponse, done, ajax);

const requestBid = JSON.parse(server.requests[0].requestBody);
expect(requestBid.ext.prebid.aliases).to.deep.equal({ bidderD: 'mockBidder' });
});

it('adds dynamic aliases to request', function () {
config.setConfig({ s2sConfig: CONFIG });

Expand Down